search

R3voA3 / 3den-Enhanced

Official 3den Enhanced repository
https://steamcommunity.com/sharedfiles/filedetails/?id=623475643
Other
48 stars 30 forks source link

Fix updating base classes #337

Closed DartRuffian closed 1 month ago

DartRuffian commented 1 month ago

Fix updating the base classes for various classes. Currently when launching the game, the following errors will be logged to the rpt:

11:40:51 Updating base class Controls->, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditMulti3/Controls/ (original a3\3den\config.bin)
11:40:51 Updating base class Controls->, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditCodeMulti3/Controls/ (original a3\3den\config.bin)
11:40:51 Updating base class EditMulti5->EditCodeMulti3, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditCodeMulti5/ (original a3\3den\config.bin)
11:40:51 Updating base class Controls->Controls, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditCodeMulti5/Controls/ (original a3\3den\config.bin)
11:40:51 Updating base class Background->Background, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditCodeMulti5/Controls/Background/ (original a3\3den\config.bin)
11:40:51 Updating base class Value->Value, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditCodeMulti5/Controls/Value/ (original a3\3den\config.bin)
11:40:51 Updating base class Title->Title, by x\enh\addons\main\config.bin/Cfg3DEN/Attributes/EditCodeMulti5/Controls/Title/ (original a3\3den\config.bin)
11:40:51 Updating base class ValueX->ctrlButton, by x\enh\addons\main\config.bin/Display3DEN/Controls/StatusBar/Controls/Version/ (original a3\3den\config.bin)
11:40:51 Updating base class RscButtonMenu->ButtonSpectatorCamera, by x\enh\addons\main\config.bin/RscDebugConsole/Controls/ButtonFunctions/ (original a3\ui_f\config.bin)

This PR fixes these errors by correcting the inheritance. For example, EditCodeMulti5 is supposed to inherit from EditMulti5; however 3den Enhanced incorrectly has it inheriting from EditCodeMulti3.

github-actions[bot] commented 1 month ago

Do not forget to also update the following files:

R3voA3 commented 1 month ago

Thanks for the PR. However, I cannot merge it like that as it removes the height changes of the edit controls and breaks the version button in the status bar.

I'll take a look at it tomorrow.

DartRuffian commented 1 month ago

I figured it would break stuff, but I'm not too familiar with all of the things that 3DEN Enhanced touches, so I figured I'd do the inheritance fixes first.

R3voA3 commented 1 month ago

I figured it would break stuff, but I'm not too familiar with all of the things that 3DEN Enhanced touches, so I figured I'd do the inheritance fixes first.

All good. I'll look into it later this week.