survey dictionary odk issues

R4EPI / epidict

Epidemiology data dictionaries and random data generators

https://r4epi.github.io/epidict/

GNU General Public License v3.0

3 stars 1 forks source link

survey dictionary odk issues #16

Closed aspina7 closed 2 years ago

aspina7 commented 2 years ago

@pbkeating putting this in an issue for now as am merging the PR so dont want to loose

[x] treatment_delay - restriction should be ${care_illness_last} = "yes", updated on github version
[x] reason_first_hf_selected restriction should be ${place_first_hf} = "other" or ${place_first_hf} = "hospital" or ${place_first_hf} = "primary_health_centre" or ${place_first_hf} = "primary_health_unit", updated on github version

variable naming consistency between vaccination and nutrition:

[x] number_children in nutrition and children_count in vaccination - should choose one and be consistent
[x] num_qua**n**d_penta_woc should be num_quad_penta_woc - updated on github version (otherwise ruins iteration)
[x] num_poliodrop_hf_woc and num_poliodrop_camp_woc should be changed to remove the num_ to be consistent with others - updated on github version (otherwise ruins iteration)

pbkeating commented 2 years ago

Updated treatment_delay and reason_first_hf_selected Changed children_count to be number_children Changed num_quand... to be num_quad

Not clear on last point since we ask how many times for the other vaccines and we have num_ before? P

aspina7 commented 2 years ago

[x] num_poliodrop_hf_woc and num_poliodrop_campwoc should be changed to remove the num to be consistent with others - updated on github version (otherwise ruins iteration)

Not clear on last point since we ask how many times for the other vaccines and we have num_ before?

but you arent consistent in your use of num_ prefix. See from this line onwards - specifically ... all the vaccines that have multiple "number of doses" questions dont have num_ infront, except for poliodrop.

pbkeating commented 2 years ago

Wasn’t clear on this point. I noticed that it should have been number_children in the repeat_count column of the short VCS. Am assuming that’s what you meant and that’s what I updated. P

From: Alex Spina @.> Sent: 08 December 2021 17:04 To: R4EPI/epidict @.> Cc: Patrick Keating @.>; Mention @.> Subject: Re: [R4EPI/epidict] survey dictionary odk issues (Issue #16)

CAUTION: This email originated from outside MSF. Do not click links, open attachments or provide information unless you recognise the sender and know that the content is safe..

@pbkeatinghttps://github.com/pbkeating

[X] number_children in nutrition and children_count in vaccination

Changed children_count to be number_children

need to swap to number_children in vaccination short too pls

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/R4EPI/epidict/issues/16#issuecomment-988999443, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE2NEQ5EV4LGEWTJUHQXPY3UP6FX7ANCNFSM5I4QO7MA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

aspina7 commented 2 years ago

@pbkeating closing this now - pls doublecheck you did all the box ticking above thankings kisses