search

R4wizard / NoitaSaveManager

A tool for managing Noita save files.
GNU General Public License v3.0
19 stars 2 forks source link

add an event and a thread to detect game start if run from steam #22

Open arnesacnussem opened 4 years ago

arnesacnussem commented 4 years ago

7

arnesacnussem commented 4 years ago

use a loop to detect if the game start but start game with extra parmas from steam url require manual confirm. from default arg, the thread wait 60*100ms for the game to start, don't know if this is good,but it works

btw, there should a dialog that indicate we're waiting for game to start,especially if we want wait unlimite time,and we should do make it wait unlimite time.

arnesacnussem commented 4 years ago

we can delete the '-no_logo_splashes' param when run it from steam to reduce steam's confirmation

R4wizard commented 4 years ago

@arnesacnussem Thank you for your contributions! I'll hopefully get a chance to review this and #23 over the weekend.

arnesacnussem commented 4 years ago

still something need to change on this, about 8hr after i'll push, then we don't need to wait for timeout.

it use a inifity loop thread to detect if game start, and should make the thread 'single instance'.

arnesacnussem commented 4 years ago

@R4wizard i've updated my code,but git push is broken on my computer, so those changes is edited on github webpage, may contains some format issue.