Statistic type missing types

stygiansabyss commented 5 years ago

Looking at the API calls the r6 site itself makes, it looks like some ops may be missing from the OPERATORPVE and PVP constants. Seems to be all year 2 and year 3 ops are missing.

Also, I don't see the r6 site calling for cazador assist kill. What is this one meant to be?

Lastly, do you know what the extra number and letters after the results map to?

      "operatorpve_death:2:4" => 73
      "operatorpve_roundlost:3:6" => 9
      "operatorpve_glaz_sniperpenetrationkill:2:4" => 36
      "operatorpve_timeplayed:3:8" => 776
      "operatorpve_kills:3:F" => 19
      "operatorpve_roundplayed:5:3" => 19
      "operatorpve_roundplayed:2:9" => 20
      "operatorpve_roundlost:3:2" => 5
      "operatorpve_buck_kill:2:6" => 62
      "operatorpve_kills:1:3" => 70
      "operatorpve_headshot:2:B" => 35

If you do, a new Type class for this could be helpful. I am happy to do a PR for you, just don't know how to figure some of this stuff out.

Thanks!

stygiansabyss commented 5 years ago

Op indexes in the API:

Index	Name	Index	Name
2:1	Smoke	3:1	Mute
4:1	Sledge	5:1	Thatcher
2:2	Castle	3:2	Ash
4:2	Pulse	5:2	Thermite
2:3	Doc	3:3	Rook
4:3	Twitch	5:3	Montagne
2:4	Glaz	3:4	Fuze
4:4	Kapkan	5:4	Tachanka
2:5	Blitz	3:5	IQ
4:5	Jager	5:5	Bandit
2:6	Buck	3:6	Frost
2:7	Blackbeard	3:7	Valkyrie
2:8	Capitao	3:8	Caviera
2:9	Hibana	3:9	Echo
2:A	Jackal	3:A	Mira
2:B	Ying	3:B	Lesion
2:C	Ela	3:C	Zofia
2:D	Dokkaebi	3:D	Vigil
3:E	Lion	4:E	Finka
2:F	Maestro	3:F	Alibi
2:10	Maverick	3:10	Clash

Extra StatisticTypes for operators:

Operator	API Key
Ying	dazzler_gadget_detonate
Lesion	caltrop_enemy_affected
Ela	concussionmine_detonate
Zofia	concussiongrenade_detonate
Dokkaebi	phoneshacked
Vigil	attackerdrone_diminishedrealitymode
Lion	tagger_tagdevice_spot
Finka	rush_adrenalinerush
Maestro	barrage_killswithturret
Alibi	deceiver_revealedattackers
Maverick	maverick_wallbreached
Clash	clash_sloweddown

I hope this helps.

Korbeil commented 5 years ago

Nice collect !

About last operators didn't got time to get them. For operators index I was aware of them from: https://github.com/r6db/r6db/wiki/Ubi-Api#get-stats

Didn't got time to make it clearer in the library, actually it's not really 'finished', I've a lot of idea to make it cleaner / smother

R6API / client

Statistic type missing types #2