RA-Consulting-GmbH / openscenario.api.test

Apache License 2.0
39 stars 12 forks source link

Apply shfmt to shell scripts #190

Closed arauschert closed 1 year ago

arauschert commented 1 year ago

Signed-off-by: Andreas Rauschert andreas.rb.rauschert@bmw.de

Reference to a related issue in the repository

Add a reference to a related issue in the repository.

Add a description

Add a description of the changes proposed in the pull request.

Some questions to ask: What is this change? What does it fix? Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version? How has it been tested?

Mention a member

Add @mentions of the person or team responsible for reviewing proposed changes.

Check the checklist

Closes: https://github.com/RA-Consulting-GmbH/openscenario.api.test/issues/191

Deakon997 commented 1 year ago

@arauschert: 👍🏽 for shfmt. I didn't know that shfmt exists. Thank you for pointing that out. For merging back to the master branch we usually have the fix in a feature branch and merge that back to the dev and then to the master. Would it be ok for you if merge your changes first to the dev (if this is possible) (then we could also merge our version number typo fix to dev) and then to the master and create a new release / patch? @ahege: is this also ok for you?

arauschert commented 1 year ago

@arauschert: 👍🏽 for shfmt. I didn't know that shfmt exists. Thank you for pointing that out. For merging back to the master branch we usually have the fix in a feature branch and merge that back to the dev and then to the master. Would it be ok for you if merge your changes first to the dev (if this is possible) (then we could also merge our version number typo fix to dev) and then to the master and create a new release / patch? @ahege: is this also ok for you?

Sure. Fine for me if its necessary.

arauschert commented 1 year ago

Created another PR for merging to the dev branch. Therefore closing this PR.