search

RACCommunity / Rex

ReactiveCocoa Extensions
MIT License
226 stars 32 forks source link

Use gyb from the Swift project for the AppKit/UIKit extensions #76

Open liscio opened 8 years ago

liscio commented 8 years ago

The MutableProperty wrappers are effectively copy & pasted with a few tweaks here & there for types, associated keys, and so on. It would be wise to figure out a way to use the gyb (Generate Your Boilerplate) tool from the Swift project to help us overcome a lot of that (sadly necessary) boilerplate.

neilpa commented 8 years ago

Good idea - https://github.com/apple/swift/blob/master/utils/gyb.py

andersio commented 7 years ago

Implemented in #142 #147. :)

dmcrodrigues commented 7 years ago

@andersio In my humble opinion, that should have been done in a separate PR and not in a branch expected to restructure/rename a lot of things and which may not be merged soon. I think this won't make our life easier because it will require a synchronization between current version targeting Swift 2.x and the new one targeting Swift 3.

andersio commented 7 years ago

@dmcrodrigues They are now split, and I have setup the RAC5 as the branch for reviewed PR like the main repo.