search

RADAR-base / RADAR-Appserver

General purpose application server for the radar platform currently with capability to schedule push notifications
10 stars 1 forks source link

Release 2.3.0 #430

Closed blootsvoets closed 1 year ago

blootsvoets commented 1 year ago

Changes since version 2.0.1:

yatharthranjan commented 1 year ago

@mpgxvii were the cors issues that popped up again fixed?

blootsvoets commented 1 year ago

Btw: in radar-Kubernetes you can fix cors by using an annotation nginx.ingress.kubernetes.io/enable-cors: "true" to the ingress

mpgxvii commented 1 year ago

@mpgxvii were the cors issues that popped up again fixed?

@yatharthranjan I haven't gotten a chance to fix it yet. Will do that today.

Btw: in radar-Kubernetes you can fix cors by using an annotation nginx.ingress.kubernetes.io/enable-cors: "true" to the ingress

@blootsvoets Okay thanks! Will try this method.

mpgxvii commented 1 year ago

Btw: in radar-Kubernetes you can fix cors by using an annotation nginx.ingress.kubernetes.io/enable-cors: "true" to the ingress

@yatharthranjan @blootsvoets Updating the ingress works. But I've also added the @CrossOrigin annotations to the controllers here: https://github.com/RADAR-base/RADAR-Appserver/pull/430/commits/8d274e46c8b4aef0ddeef842ef7f2ba917a798ee. The CORS issue might have to do with library issues (https://stackoverflow.com/questions/64892592/cors-enabled-in-spring-boot-with-angular-still-cors-errors). I've tried adding different configs to filter chain and cors configurer but no luck. I'll try to improve this later, but meanwhile adding the annotation to the controller fixes the issue.