RADAR-base / RADAR-Rest-Source-Auth

A simple application to support authorization of wearable devices using OAuth using a webservice with REST Endpoints.
https://radar-base.org/
Apache License 2.0
1 stars 0 forks source link

Add human readable #88

Closed peyman-mohtashami closed 3 years ago

peyman-mohtashami commented 3 years ago

Changes:

I checked all the pages except register page. It could be possible after deployment.

blootsvoets commented 3 years ago

Looks good, I'll verify in production. Could you add the registration form details as well? E.g. dropdown with externalId ? externalId : userId?

peyman-mohtashami commented 3 years ago

Looks good, I'll verify in production. Could you add the registration form details as well? E.g. dropdown with externalId ? externalId : userId?

This is actually not in 'register' component. The registration form is in update form, and it's been added already. I just need to test it.

peyman-mohtashami commented 3 years ago

@blootsvoets I tried to add autocomplete, but it needs some efforts for validation of input field which should be restricted to values from dropdown. I left it as a simple dropdown for now. If you think it is necessary, let me know to continue.

peyman-mohtashami commented 3 years ago

Fix "Access denied" redirection Fix "user" and "project" form select for null values.

@blootsvoets Please review last three commits.

mpgxvii commented 3 years ago

Hi @peyman-mohtashami @blootsvoets just wondering, was there a specific reasons to disable the editable fields here? I think some of the studies require some fields to remain editable.

blootsvoets commented 3 years ago

@mpgxvii iirc, the only change is that the dates are now not editable. The reason was that editing these fields would not reset the user version ID and data collection, so the rest connector would not consistently use the new dates. In the reset dialog, the dates can still be edited and the new dates are also reflected in data collection.