Add security - Githubissues

RADAR-base / RADAR-RestApi

RESTful interface to access near real-time data

Apache License 2.0

2 stars 0 forks source link

Add security #49

Closed yatharthranjan closed 6 years ago

yatharthranjan commented 6 years ago

Major changes in this PR.

Add OAuth 2.0 Security to the Rest-API based on the authentication mechanism through the Management Portal.
Use the latest version of radar-auth library(0.2.1)
Updated some POJOs according to recent changes in the MP.
Also add better exception handling and swagger doc
Create a mock MP server by creating stubs for various MP endpoints using Wiremock in a container
Point the tests to use this mock server for successful response.
Update integration Tests to include authorization
Update end-to-end Tests to include authorization
Closes #47 and #18

yatharthranjan commented 6 years ago

@dennyverbeeck thanks for the insight. I did not know the multiple forms of checkpermission() function. Is there a place where this is documented.? On radar-auth docs there is no info on the parameters this function takes. Also I am getting 401 unauthorised error and not 500 internal server error. You can also check this in the travis logs. I will add the explicit exception handling and start on tuning the changes you suggested.

dennyverbeeck commented 6 years ago

Hi @yatharthranjan, yup it's documented in the Javadoc, i'll update the Github repo so that it's more clear there as well!

yatharthranjan commented 6 years ago

@dennyverbeeck I updated the files as per the changes you requested. Just have to add the tests now

yatharthranjan commented 6 years ago

Thank a lot @dennyverbeeck for all the help and feedback !