Closed nivemaham closed 6 years ago
Seems like, i didn't really fix all the checkstyle issues
@yatharthranjan @blootsvoets Guys, can we make this a priority and finish reviewing, Please. If this is merged we can have designated branches to do upcoming changes. Since future changes could be large it is good have a separation.
:+1: Thanks both of you for your contributions. Long awaited merge.
This branch consists merges from
update_build
andread_bin_csv
branches. On top of that , i have implemented fixes such asNote: I have commented out the e2e test, since i am working on a separate
docker-compose
file to have a reducedStack. I think it will be easier to review and will give clear separation of changes that are made.This is PR is rather large, since it contains two not merged branches.