RADAR-base / fcmxmppserverv2

XMPP Connection Server for FCM using the latest version of the Smack library (4.2.4) + Connection Draining Implementation
Apache License 2.0
0 stars 0 forks source link

Fix disconnection #28

Closed yatharthranjan closed 5 years ago

yatharthranjan commented 5 years ago
yatharthranjan commented 5 years ago

Might be good to keep a monitor on the logs for disconnection (in case there are any other scenarios where this happens)

Yes that is exactly how I found this bug, as this is very internal and no error is thrown since its the expected behaviour but apparently is not documented well anywhere.

afolarin commented 5 years ago

ok great.

expected behaviour but apparently is not documented well anywhere. :thinking: you might want to send a PR upstream too

yatharthranjan commented 5 years ago

🤔 you might want to send a PR upstream too

Yes perhaps. But our codebase includes various things specific to Radar-base.