Closed Bdegraaf1234 closed 2 months ago
Great PR! Please pay attention to the following items before merging:
Files matching charts/*/values.yaml
:
This is an automatically generated QA checklist based on modified files.
This chart is giving me unintended diffs now:
I cannot set the auth url, and the baseUrl is changed
Comparing release=radar-rest-sources-backend, chart=radar/radar-rest-sources-backend
default, radar-rest-sources-backend, ConfigMap (v1) has changed:
...
labels:
- helm.sh/chart: radar-rest-sources-backend-1.1.3
+ helm.sh/chart: radar-rest-sources-backend-1.1.5
app.kubernetes.io/name: radar-rest-sources-backend
app.kubernetes.io/instance: radar-rest-sources-backend
- app.kubernetes.io/version: "4.4.2"
+ app.kubernetes.io/version: "4.4.3"
app.kubernetes.io/managed-by: Helm
...
baseUri: http://0.0.0.0:8080/rest-sources/backend/
- advertisedBaseUri: https://radar-dev.connectdigitalstudy.com/rest-sources/backend/
+ advertisedBaseUri: http://radar-dev.connectdigitalstudy.com/rest-sources/backend/
enableCors: true
Comparing release=radar-rest-sources-authorizer, chart=radar/radar-rest-sources-authorizer
default, radar-rest-sources-authorizer, Deployment (apps) has changed:
...
labels:
- helm.sh/chart: radar-rest-sources-authorizer-1.1.4
+ helm.sh/chart: radar-rest-sources-authorizer-2.0.1
app.kubernetes.io/name: radar-rest-sources-authorizer
app.kubernetes.io/instance: radar-rest-sources-authorizer
- app.kubernetes.io/version: "4.4.2"
+ app.kubernetes.io/version: "4.4.3"
app.kubernetes.io/managed-by: Helm
...
- name: BACKEND_BASE_URL
- value: https://radar-dev.connectdigitalstudy.com/rest-sources/backend
+ value: http://radar-dev.connectdigitalstudy.com/rest-sources/backend/
- name: VALIDATE
...
- name: AUTH_CALLBACK_URL
- value: https://radar-dev.connectdigitalstudy.com/rest-sources/authorizer/login
+ value: http://radar-dev.connectdigitalstudy.com/rest-sources/authorizer/login
- name: AUTH_URI
- value: https://radar-dev.connectdigitalstudy.com/managementportal/oauth2
+ value: http://radar-dev.connectdigitalstudy.com/managementportal/oauth
ports:
Maybe it is because of this PR? #226 We had similar changes to the charts recently
Description of the change
Update the rest source authorizer images
Benefits
Bugfix
Possible drawbacks
-
Applicable issues
NA
Checklist
Chart.yaml
according to semver.