migrated class to hooks

RAJAGOPALAN-GANGADHARAN / JS-OS

An Unified Operating System on the web

59 stars 27 forks source link

migrated class to hooks #50

Closed shmiitg closed 2 years ago

shmiitg commented 2 years ago

Sir I have changed the following files from using class based components to functional components. calender.js codestudio.js menubar.js minesweeper markdown_editor.js markdown_reader.js pdf.js processmanager.js

You can verify and merge. Gradually I will change all the files

RAJAGOPALAN-GANGADHARAN commented 2 years ago

Hello @shmiitg thanks for the PR, could you please remove the old code instead of commenting. That would make the pr readable. Does this break any changes?

shmiitg commented 2 years ago

Hello @shmiitg thanks for the PR, could you please remove the old code instead of commenting. That would make the pr readable. Does this break any changes?

Ok I am removing it...It won't cause any problems.

shmiitg commented 2 years ago

Done sir. You can check now

RAJAGOPALAN-GANGADHARAN commented 2 years ago

Done sir. You can check now

Thank you will review it asap

shmiitg commented 2 years ago

@RAJAGOPALAN-GANGADHARAN any updates?

RAJAGOPALAN-GANGADHARAN commented 2 years ago

@shmiitg can you please review the comments I left out?

shmiitg commented 2 years ago

@shmiitg can you please review the comments I left out?

Sorry I didn't get which comments you are talking about? Please elaborate

RAJAGOPALAN-GANGADHARAN commented 2 years ago

@shmiitg can you please review the comments I left out?

Sorry I didn't get which comments you are talking about? Please elaborate

I have left some inline comments are you not able to see it?

shmiitg commented 2 years ago

@shmiitg can you please review the comments I left out?

Sorry I didn't get which comments you are talking about? Please elaborate

I have left some inline comments are you not able to see it?

Yaah I saw them. Should I uncomment some of them or remove them? Please tell

shmiitg commented 2 years ago

While changing classes to hooks, I have kept all those comments and not removed any

RAJAGOPALAN-GANGADHARAN commented 2 years ago

This is what I meant by inline comments, Github allows us to review each line and directly specify comment. Please check that, thanks

RAJAGOPALAN-GANGADHARAN commented 2 years ago

FYI I have left more comments like this. Please check that as well

RAJAGOPALAN-GANGADHARAN commented 2 years ago

@shmiitg thank you for this PR, even though it is not merged I have granted you 15 points in the leaderboard.

shmiitg commented 2 years ago

@shmiitg thank you for this PR, even though it is not merged I have granted you 15 points in the leaderboard.

Thank you sir