search

RAKWireless / RUI3-Best-Practice

This repo provides additional examples for RUI3. It focuses on low power consumption and practical examples for range tests, location tracking and sensing applications using the WisBlock Modular System.
MIT License
8 stars 5 forks source link

Fixed addGNSS_6 function prototype #4

Closed delhiryder closed 2 months ago

delhiryder commented 2 months ago

Changed the firmware version format into one compatible with the https://semver.org/ org standard. Changed the prototype of the addGNSS_6 method to allow for negative values being passed in.

Signed-off-by: Sidd Gupta (sidd.gupta@zylum.in)

beegee-tokyo commented 2 months ago

HI @delhiryder

Thanks for the merge request. The changes in the CayenneLPP code are a real bug-fix, in my Arduino version of the code this was already fixed.

For the version name change, I prefer to keep it as is, it makes it easier to see in the debug output what type of firmware is running.

I will fix the bug and commit the changes, but I will keep the version name. But feel free to change it in your own copy of the code.