RAKWireless / WisBlock

Quickstart, tutorials and examples for the RAKwireless WisBlock product line.
https://www.rakwireless.com
MIT License
156 stars 117 forks source link

Revert Change to MTU Size #76

Open rcarteraz opened 5 months ago

rcarteraz commented 5 months ago

https://github.com/RAKWireless/WisBlock/blob/adbeffead0ebaa17a4e7b5f8978aeec606a1993d/bootloader/RAK4630/Latest/WisCore_RAK4631_Bootloader/lib/sdk11/components/libraries/bootloader_dfu/dfu_transport_ble.c#L40

https://github.com/RAKWireless/WisBlock/blob/8f5ea5ec7c8f35fefb154731d86dbf0969c26e80/bootloader/RAK4630/Latest/WisCore_RAK4631_Bootloader/src/main.c#L131

@beegee-tokyo Okay, I think these changes that were recommended in #65 and added in commit https://github.com/RAKWireless/WisBlock/commit/adbeffead0ebaa17a4e7b5f8978aeec606a1993d can be reverted. Based on my testing it's probably a better experience if it is. It appears that Nordic has improved their apps to better handle legacy and secure boot loaders so that this change seems to be no longer necessary.

I've been testing with two devices. One is running 0.4.2 bootloader and the other is running 0.4.3. I find performance is actually better on bootloader 0.4.2. 0.4.3 is now requiring setting PRN to on and turning the packet count to a very low number which is really slow. Whereas with 0.4.3 I can use the stock settings of the DFU app without issue and it runs 2-3x faster.