Release v0.5.2 - Githubissues

RAMP-project / RAMP

Repository of the open-source RAMP model for generating multi-energy loads profiles

European Union Public License 1.2

59 stars 33 forks source link

Release v0.5.2 #150

Closed Bachibouzouk closed 3 months ago

Bachibouzouk commented 4 months ago

[x] The changelog should be filled here
[x] The version number should be bumped
[x] Test release should be performed with release candidates

FLomb commented 4 months ago

Hi,

Some issues I detected:

The conversion of .py files into .xlsx files is not working again. The code looks for modules instead of files, even though we had already fixed this bug before. Apparently, it was reintroduced at some point through other means because the lines that caused the error in the past are not there anymore.
The qualitative testing functionality is not working due to some broken paths in what test_run.py tries to do.
In the docs, in 'RAMP introduction/contributing', we provide a link to the 'Contribution guidelines'. However, the link is broken - not sure if this is the case only because I am looking at the docs generated within the PR.

Bachibouzouk commented 4 months ago

The qualitative testing functionality is not working due to some broken paths in what test_run.py tries to do.

Test_run is only supposed to be runnable if you are developping and installed ramp locally with pip install -e .

Bachibouzouk commented 4 months ago

In the docs, in 'RAMP introduction/contributing', we provide a link to the 'Contribution guidelines'. However, the link is broken - not sure if this is the case only because I am looking at the docs generated within the PR.

This one at least works locally, it is most certainly a problem of file path, or maybe we need to push the copy of the Contribute.md file as well (locally the file is copied and included in the index directly as wagtail allows a mix and match of .rst and .md files)

FLomb commented 4 months ago

The qualitative testing functionality is not working due to some broken paths in what test_run.py tries to do.

Test_run is only supposed to be runnable if you are developping and installed ramp locally with pip install -e .

I've also tried using a developer version installed locally, but it still doesn't work. The BASE_PATH that it uses to create the TEST_OUTPUT_PATH gets messed up and points to a completely wrong location. I have pasted below the error message to give you an idea:

line 97, in <module>
    for file in os.listdir(TEST_OUTPUT_PATH):
FileNotFoundError: [Errno 2] No such file or directory: '/home/fl/miniconda3/envs/ramp_test_2/lib/python3.10/site-packages/rampdemand-0.5.2-py3.10.egg/ramp/test/results'