RAX-Anomaly / MagsRedux

Rework of Wuuts Mags
52 stars 21 forks source link

Can not unjam weapon if no spare magazine in loadout #274

Open misterwoo opened 1 year ago

misterwoo commented 1 year ago

I just realized i can not unjam the weapon if i only have 1 magazine for the weapon. What i mean is, if the only magazine i have for the weapon is in the gun itself and the gun jams, i cannot unjam the weapon (by pressing R). When i add a second magazine to the loadout (1 in gun, 1 in loadout) and press R - the gun unjams (unjam anim and sound plays, gun can fire again).

I tested it with all guns i had in inventory, it was like this with every gun.

Aoldri commented 1 year ago

Bug still persists, as of latest release (29/01/2023) Appears to only occur on weapons with unjam animations (e.g. Blindsides, BaS) This is likely because the engine reload is now blocked, which used to take care of unjams by reloading. Now it goes through line 584 in magazines.script, removing the weapon from the cache of jammed weapons without actually unjamming them. Meanwhile guns without animations can unjam by going through the weapon replacing logic via unjam_weapon(weapon).

VladGeros commented 1 year ago

I also noticed that after the short unjam animation it replaces the mag in the gun from the loadout. Seems like there is something wrong with the script.

xrayiii commented 1 year ago

i have the exactly same bug as Aoldri and misterwoo. i can confirm for bas weapons .

  1. when a weapon jams and you have no mgas in loadout but just in the gun and if you press R once it plays no animation but if you do ammocheck it wont say you are jammed anymore it will just show how much aprox. you have left, now if you press fire the weapon goes into jammed state again.

  2. However if you press R to unjam two times it will play an animation like for ammocheck but no actual unjamming happens.

  3. Now if you have a one mag in gun and one mag in the loadout( highligted) and weapon jams, and then you pres R one time then same situation as in the point n.1 but you press second time it will play unjam animation like its meant to, but it will perform an actual magazine change instead without reload animation. lol confusing me and shit

  4. the most bizzare to me is that i played without this bug for like 3 weeaks on multiple saves on that january 29 version abd then it appeared somehow lol. also it persists through new games new saves and debug mode after reinstaling the addon even when i revert to previous version its there BUT on the previous version it can be resolved with spamming reload and fre keys lol.

my solution is using the previous version old saves with the january version also work so meh.

hope it helps

aorushome commented 1 year ago

Any news on this? How can we fix this error? It's not a small thing. Which version are you talking about xrayiii?

xrayiii commented 1 year ago

hey, just a disclaimer. i am no authority on mods as i am a total idiot when it comes to coding or that stuff :)

but anyway this version ( MagsRedux.2022.12.08) works and you can use it on saves that have the newer mags redux versions. it has other problems but they arent worth mentioning believe me...
it is an overall improvement on the one before that

the versions after that (MagsRedux.2023.01.29 and MagsRedux.2023.06.10 ) have the bug i mentioned in my last post.

i will attach the version i am using ( MagsRedux.2022.12.08) in case you dont have it ( i store all mods and their versions versions at least the ones i like )

ps dont blame me if it dont work for u.

MagsRedux.2022.12.08.zip

aorushome commented 1 year ago

Switching out the magazines.script seems to does the trick, the other files from the new verison can be left alone. Now working with BaS or Blindeside etc. Thanks man!

Edit: seems to be working at all times, whether you have 1 mag or 2, doesnt matter.

xrayiii commented 3 months ago

as of the latest version this bug no longer happens for me

TyMeller commented 3 months ago

I´m trying the lastest version and happens the same bug.

I´m using the blindsides, BaS, Eft mods.

xrayiii commented 3 months ago

I´m trying the lastest version and happens the same bug.

I´m using the blindsides, BaS, Eft mods.

hey i am sorry to hear that:(

i dont know what happened with mine but it just stoped

no idea why