RAX-Anomaly / MagsRedux

Rework of Wuuts Mags
52 stars 21 forks source link

Crashing when initiating trade #288

Closed BismuthGenesis closed 1 year ago

BismuthGenesis commented 1 year ago

I crash when initiating trade with certain traders. Not all the time, only sometimes. This gives me the impression that it's a specific item or weapon that's crashing the game. I am using several weapon packs and stand-alone weapons but nothing that doesn't have a patch. Most often it happens with spore in the swamp, this time it happened with the trader Loris in the farm building in cordon.

FATAL ERROR

[error]Expression : [error]Function : CScriptEngine::lua_pcall_failed [error]File : ..\xrServerEntities\script_engine.cpp [error]Line : 206 [error]Description : fatal error [error]Arguments : LUA error: ...er anomaly/bin/..\gamedata\scripts\magazines_loot.script:63: attempt to compare nil with number

This is what the log always looks like. I also left a comment on the moddb page.

ferrosxlupus commented 1 year ago

So i am not part of the modding team. but i have been doing some test

this is line 206 cost_base = cost_base * 0.1 its part of the code that determines the price of the magazine in the traders inventory.

i can replicate the crash in debug just by refreshing the trader. something about the price of the magazine when being injected into the inventory is returning a no or "nil" price which isnt an option so the game is crashing. after more testing its a conflict with another mode. i dont know why buts an issue with the bas patch in the Mags_redux_models_update.6 bas patch. dont know how or why but that is causing the main issue on my end. so it has to be another magazine mod causing a conflict when injecting into the trader inventory. check them out one by one

BismuthGenesis commented 1 year ago

Yes this was the problem, I figured it out a little while after posting this. Specifically the Mags redux models update bas patch overwrites the ltx files that contain information for the kiparis and scorpion magazines and therefore the game crashes because it doesn't have info for the "cost" and other variables.