search

RBEnhanced / RB3Enhanced

Open-source plugin for Rock Band 3 providing many enhancements, fixes, and extra features.
https://rb3e.rbenhanced.rocks
GNU General Public License v2.0
57 stars 10 forks source link

How to fix pause slot positions anim properly #20

Open jnackmclain opened 2 months ago

jnackmclain commented 2 months ago

Linking a dx issue here as it was brought up there, and I cant fix it, but i figured out why https://github.com/hmxmilohax/rock-band-3-deluxe/issues/495 im no coder, but i looked in RndPropAnimHooks.c

rb3e checks if the anim frame is not 0, and if so, forces it to 2 which is correct BUT you must account for vocal players as well, as this will break certain circumstances here is what we do in dx. image

I have been banging my head on this issue but turns out its rb3e specifically. and I cant fix it on my end as rb3e overwrites the anim frame Hope this helps

jnackmclain commented 2 months ago

for context, this macro is used here so an int frame is the return value used in set_frame image