bundles/graphics: Correct bad import of LineType from chimerax.graphics

RBVI / ChimeraX

Source code for molecular graphics program UCSF ChimeraX

https://www.rbvi.ucsf.edu/chimerax/

Other

151 stars 29 forks source link

bundles/graphics: Correct bad import of LineType from chimerax.graphics #13

Closed zjp closed 1 year ago

zjp commented 2 years ago

I think this is the right import, but I've never touched our graphical backends before so I'm not 100% sure.

tomgoddard commented 2 years ago

This is an import in reuse_unlit_appearance() last modified 5 years ago by Greg and not used anywhere in ChimeraX. I am not sure how productive it is to try to patch unused code that cannot be tested. I guess you are doing it to eliminate linting errors. Maybe it would be more valuable to mark such code as unused and assign the issue to the person who wrote it.

zjp commented 2 years ago

Possibly. I don't mind if the outcome of most of these issues and PRs are getting told their subjects are dead code; it's either a live bug that needs to be fixed or more code we know we need to debride at some point.

gregcouch commented 1 year ago

Should import from .linetype, not chimerax.graphics.linetype. The code is vestigial but would be needed if unlit lines are supported again (eg., VRML or X3D data files).