search

RBVI / ChimeraX

Source code for molecular graphics program UCSF ChimeraX
https://www.rbvi.ucsf.edu/chimerax/
Other
151 stars 29 forks source link

apps/chimerax,core: ChimeraX_main.py -> core/__main__.py #17

Closed zjp closed 2 years ago

zjp commented 2 years ago

Fulfills the first of our build system items. :)

gregcouch commented 2 years ago

The run and run-nogui make targets from src/apps/ChimeraX/Makefile should also be removed. They are not debugging anything in that directory anymore. If we want to add them to the src/core/Makefile later, we can.

zjp commented 2 years ago

OK, I've fixed that issue.

zjp commented 2 years ago

Let's not merge this quite yet. There's some work left to do getting it to work for macOS. For example, mkinfo.py assumes that it can import ChimeraX_main.py, and I'm not sure we can import from a module's __main__.py so I've been unsuccessful so far getting it imported from chimerax.core.

zjp commented 2 years ago

I've moved installation of the plist on macOS to the end of the build process to stop mkinfo.py from interrupting the build.

zjp commented 2 years ago

Was able to build on Linux, Windows, and macOS after those most recent changes.

zjp commented 2 years ago

Rebased on current develop pending merge.