search

RBVI / ChimeraX

Source code for molecular graphics program UCSF ChimeraX
https://www.rbvi.ucsf.edu/chimerax/
Other
136 stars 24 forks source link

prereqs/pips: Remove blockdiag, webcolors, sphinxcontrib-blockdiag #8

Closed zjp closed 1 year ago

zjp commented 2 years ago

These packages were unused. The blockdiag extension is not mentioned in docs/devel/conf.py or docs/devel/conf.py.in.

gregcouch commented 2 years ago

Is there an alternative for putting block diagrams in the documentation? If not, and it is removed, there will be no block diagrams. Will look into webcolors after vacation.

On Mon, Nov 22, 2021, 17:30 Zach Pearson @.***> wrote:

@zjp https://github.com/zjp requested your review on: #8 https://github.com/RBVI/ChimeraX/pull/8 prereqs/pips: Remove blockdiag, webcolors, sphinxcontrib-blockdiag.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/RBVI/ChimeraX/pull/8#event-5657555872, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVICTLG2GQTJYACC7B5BMLUNLVFBANCNFSM5ISKXGZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zjp commented 2 years ago

blockdiag depends on it.

Alternatives include inheritance_diagrams and graphviz (both extensions built into sphinx) and plantuml.

But I'd reiterate that it was unused.

zjp commented 1 year ago

I no longer think that this is a good change.