search

RBVI / ChimeraX

Source code for molecular graphics program UCSF ChimeraX
https://www.rbvi.ucsf.edu/chimerax/
Other
163 stars 32 forks source link

Build: Move vsvars{,2015}.sh to mk folder #9

Closed zjp closed 3 years ago

zjp commented 3 years ago

The only beneficial thing in this PR is housekeeping; I just think these files belong in /mk

tomgoddard commented 3 years ago

Not sure this change makes sense. The mk subdirectory is for common makefiles. The vsvars shell scripts are to set up Windows compilers under cygwin to do builds.

zjp commented 3 years ago

Should it always be for common makefiles, or could it be for setting up the environment regardless of platform?

tomgoddard commented 3 years ago

The directory name mk does not suggest it is generic build setup. Maybe build related scripts could go into a new subdirectory. Greg has mostly managed builds.

gregcouch commented 3 years ago

That's not appropriate. The mk folder is for make include files.

On Tue, Nov 30, 2021 at 3:22 PM Zach Pearson @.***> wrote:

@zjp https://github.com/zjp requested your review on: #9 https://github.com/RBVI/ChimeraX/pull/9 Build: Move vsvars{,2015}.sh to mk folder.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/RBVI/ChimeraX/pull/9#event-5695312321, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVICTLBTMESRKHH2NTZIBLUOVMCXANCNFSM5JC5NOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.