Closed GoogleCodeExporter closed 8 years ago
OK, I will fix this. It looks like Google's own build scripts account for
spaces. (See _BASE_REGEX_STRING in
http://code.google.com/p/closure-library/source/browse/trunk/closure/bin/build/s
ource.py.)
Though this may not be important to you, code written using all those spaces is
unlikely to pass the Closure Linter checks:
http://code.google.com/p/closure-linter/
Original comment by bolinf...@gmail.com
on 11 Apr 2011 at 1:37
Too bad spaces are bad, I find it makes code more readable. Funny you should
mention closure-linter, that's next on my list to set up. Does plovr have an
option to run the linter too? Thanks for the quick response.
Original comment by jwfe...@gmail.com
on 11 Apr 2011 at 2:22
And you're right about Google's scripts: the code with spaces, built by hand
with calcdeps.py et al, compiles with no errors using the versions of
closure-library and closure-compiler I downloaded two days ago.
Original comment by jwfe...@gmail.com
on 11 Apr 2011 at 2:25
plovr doesn't run the linter yet, though it's on my list. I think I want to use
Jython (http://www.jython.org/) so that users can avoid installing the Python
runtime to use plovr. Installing Python can be a pain point for Windows users.
Original comment by bolinf...@gmail.com
on 11 Apr 2011 at 2:26
Jython sounds like a good solution, would you add that to the plovr bundle? I
like the fact that plovr is a single .jar file. For anyone experiencing
"Python pain" now, I can recommend the ActiveState Python distros because they
come with a Windows installer.
Original comment by jwfe...@gmail.com
on 11 Apr 2011 at 3:24
I forgot to mention, ActivePython
(http://www.activestate.com/activepython/downloads) is free.
Original comment by jwfe...@gmail.com
on 11 Apr 2011 at 3:25
Fixed in 1950:b76f03f139b5
Original comment by bolinf...@gmail.com
on 24 Apr 2011 at 2:27
Original issue reported on code.google.com by
jwfe...@gmail.com
on 11 Apr 2011 at 5:39Attachments: