Plovr shouldn't instantiate its own closure-compiler Result objects

RC-Paves3-build / plovr

Automatically exported from code.google.com/p/plovr

0 stars 0 forks source link

Plovr shouldn't instantiate its own closure-compiler Result objects #87

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

here's a patch file that demonstrates how to do this properly:
https://github.com/Obvious/plovr/commit/38ba9df1d0de4307350c72b1494c70aa15b22a69
.patch

As you can see, the 'right' way is much shorter. Let me know if you would like 
me to submit this sort of patch in a different form.

Original issue reported on code.google.com by Nicholas.J.Santos on 16 May 2013 at 5:14

GoogleCodeExporter commented 8 years ago

Thanks for the patch! Fixed:

http://code.google.com/p/plovr/source/detail?r=4df6a0e20e676fc87acaf6dd2e327ae57
4935728

Original comment by bolinf...@gmail.com on 2 Jul 2013 at 3:39

GoogleCodeExporter commented 8 years ago

Original comment by bolinf...@gmail.com on 2 Jul 2013 at 3:40

Changed state: Fixed