search

RC-Paves3-build / plovr

Automatically exported from code.google.com/p/plovr
0 stars 0 forks source link

BuildCommand formats closure-compiler errors incorrectly #88

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
BuildCommand currently just calls toString() on JSError objects. This gives you 
the output that closure-compiler developers use for debugging, but it's not 
great for real users.

Here is a patch that just uses closure-compiler's error-formatting API.
https://github.com/Obvious/plovr/commit/93a1147a4796a37140aa21e8223c5b85867b17d5
.patch
you can ignore the package.json stuff; the meat of the changes are in 
Config.java and BuildCommand.java.

Again, let me know if there's a better way to propose these patches.

Original issue reported on code.google.com by Nicholas.J.Santos on 16 May 2013 at 5:18

GoogleCodeExporter commented 8 years ago 
Can you submit a pull request on GitHub?

Original comment by bolinf...@gmail.com on 16 Jul 2013 at 6:46

GoogleCodeExporter commented 8 years ago 
will do

Original comment by Nicholas.J.Santos on 16 Jul 2013 at 9:02