[BUG] Tool crashes midgame in game

[benholness]

Describe the bug The tool crashes during in game randomly without any error message popup or indication in the League Prod Toolkit console.

To Reproduce Steps to reproduce the behavior:

1. Load up League of Legends and start up the League Prod Toolkit via start.bat
2. Once server is started, load up League Observer Tool and sync up all elements for both Client and In Game tabs.
3. Start up game (happens both for live spectator and replays).
4. Without any indiciation, the tool crashes midgame (no specific time it happens).

Expected behavior To not crash at all or at the very least show the error message of what the issue at hand is/why it crashed.

System:

• OS: Windows 10
• Version: 10.0.19045
• League Observer Tool Version: 6.2.5

Additional context Main Log (the error message in here could be related to the bug I've described above, but I'm not 100% sure as it happened on 06/08/2023 as well and I don't see any errors logged even though it crashed that day too): main.log

[benholness]

As an extra bit of info to see this live in action, this happened when I was casting some games on stream multiple times (you can see it around the 40 mins 40 second mark where the timer freezes at 07:02 and it stops updating the scoreboard). The program just closes itself randomly for some reason. In the Twitch VOD someone messaged me that it was frozen and I realise at 48 mins in.

https://www.twitch.tv/videos/1889182971

[sdomi4]

Is there no output on the console before the crash or does the console just close before you can see / copy out any errors?

[benholness]

So there are no errors in the console for League Prod Toolkit and the League Observer Tool just closes itself.

[benholness]

I'm casting another game tonight so I'll see if anything happens but this has happened ever since I updated the League Observer Tool to 6.2.5

[sdomi4]

Are you positive this only started happening with 6.2.5? That would allow us to narrow down the issue.

[benholness]

I'm 99% sure I didn't have the program crash like this before the update. Most of the errors I've had in the past were Farsight related and showed up in the League Pro Toolkit console.

[benholness]

Hey @sdomi4 and @Himyu, done a cast yesterday after I updated League Prod Toolkit to 1.6.1 and it didn't crash once.

I assume 6.2.5 didn't like 1.6.0 of League Prod Toolkit 👍

[Himyu]

Ok perfect, I will have a look into it but if that fixed your issue that's great.

[MDvorky]

It keeps crashing and freezing the scoreboard. Also shrinking my middle logo of the series. Can you please help me somehow? I did not have this issue two versions before so i dont know what to do. Im casting almost every day :/

[MDvorky]

Also recieving this message - don't know what to do, because i did update the config and live.events in install folder. There was additional dragonsoulgiven line. Don't know if that's right or not. And as well this is kinda strange - is this normal?

[sdomi4]

Please keep things to one place, we are looking into adding logs to troubleshoot the issue further.

[MDvorky]

Okay, but i don't know what can i do right now. Just wait - tried to do some thing, i will test it today and let you know.

[MDvorky]

It's still crashing. I dont know what else i Can do.

[Himyu]

As we told you before we can not help you if you do not provide details of the problems. We need more descriptions, logs, etc to find out what is wrong if you don't offer that we can not help you.

[MDvorky]

If your can tell me where Can i find logs or whatever, i will show it to you. But from where i Can pull logs if app crashes?

[Himyu]

you can find your logs under 'AppData\Roaming\league-observer-tool\logs'

[MDvorky]

@Himyu Here is the log: main.log

[sdomi4]

Is the error logged at 2023-08-15 12:24:23.945 the same time when the observer tool crashed? Or was the crash at 2023-08-15 12:42:03.429?

[MDvorky]

crash happened at 12:42:03 but i started program at 12:24.

[MDvorky]

I found this in Config - maybe this was causing the issue:

{ "server-ip": "127.0.0.1", "server-port": 3003, "server-api-key": "RCVPT-YV7BQ3X-AAX4AQ2-G17RDCA-EP3M4ME", "live-events-port": 34243, "replay-send-information": true, "league-install-path": "C:\Riot Games\League of Legends" }

[MDvorky]

so i replaced it and put the thingies which are in the guide.

[MordredXYZ]

I'd also like to report I'm getting CONSISTENT crashes from the observer tool, and have been for quite some time but up until I saw this thread, believed it to be my machines.

I've had the tool crash twice while testing my setup. Scratch that, it just crashed as I was typing that, and with ZERO log output.

Just crashed now at 8:24PM, and last log entry was when I reopened it, AGAIN, at 8:15pm. main.log

With multiple crashes a game, this is... unreliable at best.

[MordredXYZ]

The tool also consistently prompts me to fix my game config, even though nothing has changed and my client is set up correctly. That is likely another, separate issue however.

[Himyu]

Just a couple of questions to narrow down the origin of the bug. The prod tool itself is no issue and does not show any errors?

Are you using the auth feature or not?

Are you using all features of the observer tool?

Can you provide your config without sensitive data to check so settings?

[Himyu]

The tool also consistently prompts me to fix my game config, even though nothing has changed and my client is set up correctly. That is likely another, separate issue, however.

Yes that would be a separate issue please.

[MDvorky]

@Himyu If i may, im recieving some error in prod tool. I'm using auth I'm using all the features - whic i can. And this is my config. I already past the log file here but i can do i t again. Today it crashes again for a few times. I was forced to use not my great overlay but basic which was pitty.

[MDvorky]

@Himyu This error i constantly recieving

[sdomi4]

403 usually indicates an issue with the API key. There are also some issues with the APIs on Riots side (spectator-v4 which provides info on runes and some other things is broken)

[MDvorky]

But I did not have it few versions before. So there is nothing I can do about it?

[benholness]

I'm getting the same error btw about the Live Events Config being incomplete when I load up the program. I checked my LiveEvents.ini and it has this. Is this all the correct elements the file needs to have?

OnMinionKill
OnNeutralMinionKill
OnDamageGiven
OnKillDragon_Spectator
OnKillRiftHerald_Spectator
OnKillWorm_Spectator
OnTurretPlateDestroyed
OnDragonSoulGiven

[benholness]

Every time I load the program it prompts me to say my game configs are missing or not complete. And when I click yes it just adds the following on top of what I have above in my LiveEvents.ini but doesn't solve the error (it basically just duplicates what I have):

OnKillDragon_Spectator
OnKillRiftHerald_Spectator
OnKillWorm_Spectator
OnTurretPlateDestroyed
OnDragonSoulGiven

Any thoughts on this? Let me know if there is any additional information you guys need and I'll be happy to pass it on to help resolve this.

I've also tried a fresh install but the same issue comes up unfortunately.

[benholness]

In addition to this the overlays work as expected (the scoreboard is fine) however level up popups, item popups and the ingame leaderboards don't work (leaderboards are empty). I have all this switched on in the in-game area of League Prod Toolkit so I assume its an issue with League Observer Tool not fetching the needed data for it.

My Riot API key is up-to-date as well.

[Himyu]

regarding the 403 issue, there is nothing we can do since that means either the API key is not valid or an action is blocked by Riot. we can check out what exactly is causing this, but we probably cant do anything about that.

[benholness]

No worries @Himyu, thank you for the update. We appreciate everything you guys are doing for this ♥

[Himyu]

When it comes to the config issue, I will have a look into it. but unfortunately, i can not reproduce this issue on my side

[benholness]

Thank you, let me know if there's anything I can do to help provide you with the needed info to replicate it. Must be a devs worst nightmare with the whole 'it's working on my machine but why not yours'

[Himyu]

is your game.cfg locked for modification? A lot of people do that so the riot client does not mess up their configs. and is that happening on the normal server or tournament realm?

[benholness]

Hey @Himyu, so I've had a look and I can edit my game.cfg file but not 100% sure how to check if it's locked. Is there a way to check?

And this is happening in normal server games on EUW (i.e spectating custom tournament draft games and spectating normal games)

[MDvorky]

Me as well have this issue in normal games.

[Himyu]

Okay, it will take some time to find and fix this issue. We will update you as soon as we know more about it.

[MDvorky]

So yesterday i downloaded new version of both - but tool crashed me at 2. minute. If i can send the logs, i will but can you help? It is pitty to not having this app running. :/

[sdomi4]

We are working on narrowing down the issue – unfortunately the logs don't catch the issue at the moment. You can try disabling the LiveEvents connector for better stability of the observer tool, but will lack Objective Kills and Platings showing up properly.

[MDvorky]

I'm not using Platings anyway - i'm focusing more on scoreboard and baron timers :) Thank you for amazing job.

[yourideraadt]

Hey, so I indeed also encountered the error, and was able to replicate it somewhat easily. By watching back a previous game in spectator, and skipping back and forth constantly through the match it would crash relatively quickly (within 10 seconds). I hope this helps to find what is causing the issue. EDIT: After further messing about I'm pretty sure it's related to farsight, as I can skip about with it disabled with no issues, once I turn it on however it crashes almost instantly when I do the same

[sdomi4]

Skipping around in time is not really an intended use case for the observer tool, as it's expected to run on the main obs client; so that's not something we account/test for.

[FireFoXz09]

Just to update or add to maybe help track. Fresh update on my side of the observer tool and the prod toolkit on a new PC. First time spectating a game, the observer tool crash at around 38 minutes mark. I'll do more test with more games but no log available about this crash. I will try disabling the LiveEvents connector to see if this add some stability or not.

[yourideraadt]

From my experience it has been specifically related to farsight. I've been extensively testing and using the program while developing a custom overlay, and crashes only occured when farsight was enabled. So I can 99% confidently say it is related to that. And this was not with skipping back and forth as mentioned in my previous comment.

[sdomi4]

We haven't been able to fully narrow down the issue, but version 6.5.2 should hopefully be more resilient to crashes (and log more information surrounding crashes). If you continue seeing crashes (we haven't been able to consistently reproduce any without skipping around the timeline) please add a comment with the log file, and note whether or not you were skipping around the timeline.

[FireFoXz09]

Still crashes randomly with patch 6.5.2 (on this example, at 10 minutes 3 seconds IGT). Here's the log. It was from a downloaded replay. I did not touch the timeline, or skip time, or go faster, etc. I just let the replay go and wait until the Observer Tool stop running and close. The toolkit still run and don't say any error.

main.log

[yourideraadt]

I can definitely confirm that it is related to farsight, as it still happens in the latest version. I only had the farsight module synced, and none of the others, and after just spectating a game for a couple of minutes it spontaneously crashed. I suspect maybe it could be windows version related, I am using windows 10 as well as the initial poster, but otherwise I have no clue, as the crashing is highly inconsistent.