RCVolus / league-prod-toolkit

Toolkit for League Productions with overlays for champion select, ingame events, end of game stats, and more
MIT License
136 stars 25 forks source link

New features are not working #146

Closed shir0xyz closed 1 year ago

shir0xyz commented 2 years ago

Custom killfeed, objective kills and platings are not working as of 27.10.2022. I didn't get any erros while kills happened. Observer tool is synced up with every option. Inhibitors are not working as well.

Himyu commented 2 years ago

did you also sync all the ingame modules in your observer tool (attach a screenshot if possible) and can you please confirm that you have set the config in the ingame module correctly (attache screenshot as well)?

shir0xyz commented 2 years ago

cfgsc ot1 ot2

shir0xyz commented 2 years ago

Update: we've reinstalled observer tool, toolkit server and kills started to work. We're waiting on events for platings and objectives.

Himyu commented 2 years ago

Can you please also provide a screenshot of your ingame module config? Should look something like this image

shir0xyz commented 2 years ago

image

Himyu commented 2 years ago

Ok perfect! Did you add a LiveEvents.ini file to your LoL Config folder? if not please do so and add the following content to it:

OnKillDragon_Spectator
OnKillRiftHerald_Spectator
OnKillWorm_Spectator
OnTurretPlateDestroyed
OnDragonSoulGiven
shir0xyz commented 2 years ago

We have first three values, we'll add those 2 last. Would it work mid-game?

Himyu commented 2 years ago

no, unfortunately it will not you would have to restart the game for changes to take effect

shir0xyz commented 2 years ago

Alright thanks, I'll let you know how it works when we'll head to next game.

Himyu commented 2 years ago

Ok thank you for the feedback so far and good luck for the next one

shir0xyz commented 2 years ago

We have killfeed and inhibitors, but objectives and platings are still not working.

Himyu commented 2 years ago

After changing your config did you also close your League client completely? Because League only includes changes to the config and the Config folder when the client is started.

shir0xyz commented 2 years ago

Yes, we restarted a couple of times

Himyu commented 2 years ago

If you could try it ones more because some times it does not work on the first go?

shir0xyz commented 2 years ago

Another week and another not working plates. As of new features, delay is not working, nameplates and baron power-play are working. Update: drake and baron are working as expected, no idea why only after reset. Probably the problem is us watching some replays in between.

shir0xyz commented 2 years ago

New observation, backend server is crashing when the game ends. I'll provide the screenshot later.

Himyu commented 2 years ago

do you have all the newest patch for the plugins, I know this issue but there should be a fix for it. But I wait for your screenshot to know more

shir0xyz commented 2 years ago

Backend server was updated by me today few hours ago, so it all should be up to date

Himyu commented 2 years ago

i don't mean the server itself i rather mean the plugins and modules

shir0xyz commented 2 years ago

Just confirmed, platings are working. My only concern now are delay and those crashes at the end of the game

shir0xyz commented 2 years ago

Just got a random crash mid-game. image

Himyu commented 2 years ago

can you give me a screenshot of your module page (http://localhost:3003/modules) when the toolkit is open

shir0xyz commented 2 years ago

image

shir0xyz commented 2 years ago

Also on side note, I could use some instructions for Twitch module

Himyu commented 2 years ago

Instruction for the twitch module will be added to the wiki shortly. And for your crash, there will be fix by tomorrow as well.

shir0xyz commented 2 years ago

Awesome, any chances for update in terms of delay thing?

Himyu commented 2 years ago

What exactly is not working when using the delay?

shir0xyz commented 2 years ago

Well it's not delaying the ingame overlays

Himyu commented 2 years ago

ok i will have a look at that tomorrow as well

shir0xyz commented 2 years ago

Thank you very much

Himyu commented 2 years ago

How much delay did you set to test it?

shir0xyz commented 2 years ago

3, I guess it's measured by seconds

Himyu commented 2 years ago

Ok pls try it with 3000 since its measured I'm milliseconds I will ad so note to the ui for that

shir0xyz commented 2 years ago

And now delay is working

Himyu commented 2 years ago

Another question, your crash after the game, was that for a customer game or a normal game?

shir0xyz commented 2 years ago

It's all during custom games

shir0xyz commented 2 years ago

It seems like delay is messing with timer of baron power-play

Himyu commented 2 years ago

messing in wich way?

Himyu commented 2 years ago

and the crash has been fixed with the latest patch of module league state https://github.com/rcv-prod-toolkit/module-league-state/releases/tag/v4.8.1

shir0xyz commented 2 years ago

messing in wich way?

It shows 00:00 instead of countdown

Himyu commented 2 years ago

Ok, I had this issue during development face but fixed it before making it public. If you try downloading the newest version of the in-game module it might fix the issue If not, I will have a new look at it.

shir0xyz commented 2 years ago

Updating game state and ingame modules didn't fix power-play timer

shir0xyz commented 2 years ago

And yes, the server is not crashing but it's reloading everything

shir0xyz commented 2 years ago

Another crash just popped up image

shir0xyz commented 2 years ago

Something must have broke and I lost all player names from draft overlay

Himyu commented 1 year ago

And yes, the server is not crashing but it's reloading everything

what do you mean by reloading everything?

shir0xyz commented 1 year ago

It acts like it crashed but cmd windows stays untouched

Himyu commented 1 year ago

ah, I saw today what you mean I will try to find a solution for that. For the delay, breaking the power play timer, I added a patch today.

Himyu commented 1 year ago

I also added a path to the module league static to fix the in-game reset. If you try it out let me know how it went.