Closed JoanJuan10 closed 1 year ago
sdomi4
commented
1 year ago This is due to customised variants of the champ select module / custom themes we haven't made public.
You should be able to exclude the submodules in question (module-league-champselect-ace, module-league-champselect-tent, as well as the themes theme-league-ace-gaming, theme-league-tent, and theme-valorant-shooting-stars from the update either in your git config or when updating.
JoanJuan10
commented
1 year ago Hello there. Thank you for the answer.
Following with the next step, I encountered a problem with building the modules. Here's what pops up whenever I build all modules:
Joan@DESKTOP-P13L8VS MINGW64 /e/repositorios/league-prod-toolkit (main)
$ npm run build:modules
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
> league-prod-toolkit-core@1.3.7 build:modules
> node dist/utils/build-modules.js
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module 'E:\repositorios\league-prod-toolkit\dist\utils\build-modules.js'
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
at node:internal/main/run_main_module:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
And here is what pops up when I try to build one of them alone:
Joan@DESKTOP-P13L8VS MINGW64 /e/repositorios/league-prod-toolkit (main)
$ npm run build:modules module-league-static
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
> league-prod-toolkit-core@1.3.7 build:modules
> node dist/utils/build-modules.js
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module 'E:\repositorios\league-prod-toolkit\dist\utils\build-modules.js'
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
at node:internal/main/run_main_module:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}NPM version (I don't know if it's too new. But I don't think its related to my problem):
Joan@DESKTOP-P13L8VS MINGW64 /e/repositorios/league-prod-toolkit (main)
$ npm -v
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
8.13.2This error probably appears since the main project isn't built yet.
Should be fixed by executing npm install (if you haven't yet) and npm run build before npm run build:modules.
I have updated the wiki to reflect the full process :)
The npm version should be fine, note we develop and test on node 16.7; newer version probably break things more or less badly.
JoanJuan10
commented
1 year ago Thank you for everything. The npm install and build commands work as intended. The only problem now is that the npm run build:modules throws some errors since it's missing the modules we skipped before.
Here is a dump of everything that throws the build:modules command.
Joan@DESKTOP-P13L8VS MINGW64 /e/repositorios/league-prod-toolkit (main)
$ npm run build:modules
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
> league-prod-toolkit-core@1.3.7 build:modules
> node dist/utils/build-modules.js
installing module-caster
installing module-league-caster-cockpit
installing module-league-champselect-ui
installing module-league-end-of-game
installing module-league-in-game
installing module-league-prm
installing module-league-state
installing module-league-static
installing module-teams
installing module-tournament-tree
installing module-twitch
installing module-valorant-pregame
installing module-valorant-state
installing module-valorant-static
installing module-vmix
installing plugin-config
installing plugin-database
installing plugin-prod-clock
installing plugin-theming
installing plugin-webapi
installing rcv-gfx
Failed to install module: module-league-champselect-ui, Error: Command failed: npm ci
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@7.20.7
npm WARN Found: @babel/core@7.5.5
npm WARN node_modules/@babel/core
npm WARN dev @babel/core@"7.5.5" from the root project
npm WARN 106 more (@babel/helper-compilation-targets, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @babel/core@"^7.13.0" from @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@7.20.7
npm WARN node_modules/@babel/preset-env/node_modules/@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining
npm WARN @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@"^7.18.9" from @babel/preset-env@7.20.2
npm WARN node_modules/@babel/preset-env
npm WARN
npm WARN Conflicting peer dependency: @babel/core@7.20.12
npm WARN node_modules/@babel/core
npm WARN peer @babel/core@"^7.13.0" from @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@7.20.7
npm WARN node_modules/@babel/preset-env/node_modules/@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining
npm WARN @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@"^7.18.9" from @babel/preset-env@7.20.2
npm WARN node_modules/@babel/preset-env
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @babel/plugin-proposal-class-static-block@7.20.7
npm WARN Found: @babel/core@7.5.5
npm WARN node_modules/@babel/core
npm WARN dev @babel/core@"7.5.5" from the root project
npm WARN 106 more (@babel/helper-compilation-targets, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @babel/core@"^7.12.0" from @babel/plugin-proposal-class-static-block@7.20.7
npm WARN node_modules/@babel/preset-env/node_modules/@babel/plugin-proposal-class-static-block
npm WARN @babel/plugin-proposal-class-static-block@"^7.18.6" from @babel/preset-env@7.20.2
npm WARN node_modules/@babel/preset-env
npm WARN
npm WARN Conflicting peer dependency: @babel/core@7.20.12
npm WARN node_modules/@babel/core
npm WARN peer @babel/core@"^7.12.0" from @babel/plugin-proposal-class-static-block@7.20.7
npm WARN node_modules/@babel/preset-env/node_modules/@babel/plugin-proposal-class-static-block
npm WARN @babel/plugin-proposal-class-static-block@"^7.18.6" from @babel/preset-env@7.20.2
npm WARN node_modules/@babel/preset-env
npm ERR! code EUSAGE
npm ERR!
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR!
npm ERR! Missing: semver@6.3.0 from lock file
npm ERR!
npm ERR! Clean install a project
npm ERR!
npm ERR! Usage:
npm ERR! npm ci
npm ERR!
npm ERR! Options:
npm ERR! [--no-audit] [--foreground-scripts] [--ignore-scripts]
npm ERR! [--script-shell <script-shell>]
npm ERR!
npm ERR! aliases: clean-install, ic, install-clean, isntall-clean
npm ERR!
npm ERR! Run "npm help ci" for more info
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Joan\AppData\Local\npm-cache\_logs\2023-02-20T14_58_28_498Z-debug-0.log
installed module-league-champselect-ui
====================
start building module-league-champselect-ui
> module-league-champselect-ui@1.6.0 build
> node scripts/build.js
Error: Command failed: npm run build
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module 'dotenv-expand'
Require stack:
- E:\repositorios\league-prod-toolkit\modules\module-league-champselect-ui\config\env.js
- E:\repositorios\league-prod-toolkit\modules\module-league-champselect-ui\scripts\build.js
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at E:\repositorios\league-prod-toolkit\modules\module-league-champselect-ui\config\env.js:35:5
at Array.forEach (<anonymous>)
at Object.<anonymous> (E:\repositorios\league-prod-toolkit\modules\module-league-champselect-ui\config\env.js:33:13)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
at Module.load (node:internal/modules/cjs/loader:981:32) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'E:\\repositorios\\league-prod-toolkit\\modules\\module-league-champselect-ui\\config\\env.js',
'E:\\repositorios\\league-prod-toolkit\\modules\\module-league-champselect-ui\\scripts\\build.js'
]
}
at ChildProcess.exithandler (node:child_process:398:12)
at ChildProcess.emit (node:events:527:28)
at maybeClose (node:internal/child_process:1092:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
code: 1,
killed: false,
signal: null,
cmd: 'npm run build'
}After that, it starts to build and it seems all existing modules work and build as intended.
installed module-league-caster-cockpit
installed plugin-config
installed module-league-end-of-game
installed plugin-prod-clock
installed module-tournament-tree
installed module-caster
installed module-valorant-state
installed module-valorant-pregame
installed module-vmix
installed module-twitch
installed module-league-in-game
installed module-league-state
installed module-teams
installed module-valorant-static
installed plugin-theming
installed plugin-database
installed module-league-static
installed rcv-gfx
====================
start building plugin-config
> plugin-config@3.0.4 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-caster-cockpit
> module-league-caster-cockpit@0.10.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-end-of-game
> module-league-end-of-game@1.4.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building plugin-prod-clock
> plugin-prod-clock@1.1.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-caster
> module-caster@2.0.3 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-valorant-state
> module-valorant-state@1.7.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-teams
> module-teams@4.2.1 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-vmix
> module-vmix@0.8.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-twitch
> module-twitch@1.1.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-state
> module-league-state@4.9.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-in-game
> module-league-in-game@3.6.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed module-league-prm
====================
start building module-league-static
> module-league-static@3.9.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-valorant-static
> module-valorant-static@1.3.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-valorant-pregame
> module-valorant-pregame@1.2.8 build
> npm run compile-sass && tsc
> module-valorant-pregame@1.2.8 compile-sass
> sass frontend/gfx/:frontend/gfx/
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building plugin-database
> plugin-database@2.3.3 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed plugin-webapi
====================
start building plugin-theming
> plugin-theming@1.2.4 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-tournament-tree
> module-tournament-tree@1.2.8 build
> npm run compile-sass && tsc
> module-tournament-tree@1.2.8 compile-sass
> sass frontend/style/:frontend/style/
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building rcv-gfx
> rcv-gfx@1.1.1 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-prm
> module-league-prm@1.0.1 build
> tsc
Thank you for the help!
sdomi4
commented
1 year ago The error is not related to the other submodules; it's actually failing to build. We'll take a look to see what's happening. The precompiled version should work in case you don't plan to modify champ select.
JoanJuan10
commented
1 year ago I used the precompiled version and it is now building. It seems to be missing a compile saas script somewhere though.
Joan@DESKTOP-P13L8VS MINGW64 /e/repositorios/league-prod-toolkit (main)
$ npm run build:modules
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
> league-prod-toolkit-core@1.3.7 build:modules
> node dist/utils/build-modules.js
installing module-caster
installing module-league-champselect-ui
installing module-league-caster-cockpit
installing module-league-end-of-game
installing module-league-in-game
installing module-league-prm
installing module-league-static
installing module-league-state
installing module-teams
installing module-tournament-tree
installing module-twitch
installing module-valorant-pregame
installing module-valorant-state
installing module-valorant-static
installing plugin-config
installing module-vmix
installing plugin-database
installing plugin-theming
installing plugin-prod-clock
installing plugin-webapi
installing rcv-gfx
installed module-league-end-of-game
installed module-league-caster-cockpit
installed plugin-database
installed module-valorant-state
installed module-league-in-game
installed module-caster
installed plugin-config
installed module-league-static
installed module-league-state
installed module-twitch
installed module-valorant-pregame
installed module-teams
====================
start building module-league-caster-cockpit
> module-league-caster-cockpit@0.10.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed plugin-prod-clock
====================
start building plugin-database
> plugin-database@2.3.3 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-end-of-game
> module-league-end-of-game@1.4.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-valorant-state
> module-valorant-state@1.7.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-in-game
> module-league-in-game@3.6.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-caster
> module-caster@2.0.3 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building plugin-config
> plugin-config@3.0.4 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed module-valorant-static
installed module-vmix
installed module-tournament-tree
installed plugin-theming
====================
start building module-league-static
> module-league-static@3.9.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-league-state
> module-league-state@4.9.5 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed rcv-gfx
====================
start building plugin-prod-clock
> plugin-prod-clock@1.1.5 build
> tsc
Error: Command failed: npm run build
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm ERR! Missing script: "compile-sass"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR! npm run
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Joan\AppData\Local\npm-cache\_logs\2023-02-20T15_20_16_681Z-debug-0.log
at ChildProcess.exithandler (node:child_process:398:12)
at ChildProcess.emit (node:events:527:28)
at maybeClose (node:internal/child_process:1092:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
code: 1,
killed: false,
signal: null,
cmd: 'npm run build'
}
====================
start building module-twitch
> module-twitch@1.1.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-teams
> module-teams@4.2.1 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed module-league-prm
====================
start building module-vmix
> module-vmix@0.8.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-valorant-static
> module-valorant-static@1.3.2 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building plugin-theming
> plugin-theming@1.2.4 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building rcv-gfx
> rcv-gfx@1.1.1 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-valorant-pregame
> module-valorant-pregame@1.2.8 build
> npm run compile-sass && tsc
> module-valorant-pregame@1.2.8 compile-sass
> sass frontend/gfx/:frontend/gfx/
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
====================
start building module-tournament-tree
> module-tournament-tree@1.2.8 build
> npm run compile-sass && tsc
> module-tournament-tree@1.2.8 compile-sass
> sass frontend/style/:frontend/style/
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed plugin-webapi
====================
start building module-league-prm
> module-league-prm@1.0.1 build
> tsc
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
installed module-league-champselect-ui
====================
start building module-league-champselect-ui
> module-league-champselect-ui@1.6.0 build
> node scripts/build.js
Creating an optimized production build...
Compiled successfully.
File sizes after gzip:
42.87 kB build\static\js\2.5838ddc5.chunk.js
9.58 kB build\static\js\main.1228372d.chunk.js
801 B build\static\js\runtime~main.4bf0a0a6.js
211 B build\static\css\main.266321ad.chunk.css
The project was built assuming it is hosted at /pages/op-module-league-champselect-ui/.
You can control this with the homepage field in your package.json.
The build folder is ready to be deployed.
Find out more about deployment here:
https://cra.link/deployment
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
Joan@DESKTOP-P13L8VS MINGW64 /e/repositorios/league-prod-toolkit (main)Edit: Actually it doesn't seem to build. Only that module is.
sdomi4
commented
1 year ago The failed build was down to a missing dependency. You can either manually install dotenv-expand or pull the newest version to resolve the issue.
Is your question related to a problem? Please describe. Following the Developer Documentation. On a fresh clone, I am having problems gathering the submodules and all folders seem empty.
Describe alternatives you've considered I have tried doing the same after on a sucessful install and neither seems to work.
Additional context Here's the cmd output: