RCVolus / league-prod-toolkit

Toolkit for League Productions with overlays for champion select, ingame events, end of game stats, and more
MIT License
136 stars 25 forks source link

[ Bug ] Caster Cockpit `Copy Action-Link` buttons copy wrong url #396

Closed JanRogge closed 1 year ago

JanRogge commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Caster Cockpick frontend'
  2. Click on any 'Copy Action-Link' button
  3. Paste copied link somewhere
  4. See that euw instead of the webserver is used.

Expected behavior Correct link is copied

Screenshots If applicable, add screenshots to help explain your problem.

System:

Additional context The problem here should be that in cockpit.js the server is used for the op.gg link generation but then in the html it is assumed that $server is the host like in all other copy cases.

Himyu commented 1 year ago

This is fixed with the newest version of the caster cockpit module v0.11.0