RCVolus / league-prod-toolkit

Toolkit for League Productions with overlays for champion select, ingame events, end of game stats, and more
MIT License
131 stars 25 forks source link

[ Bug ] Syntax Error doesn't start the toolkit #462

Closed casbahcasts closed 1 year ago

casbahcasts commented 1 year ago

Describe the bug The Toolkit does not start since the newest update (see screenshot). is that on my end or is it just because of the new league patch and it still is missing some updates? I even tried to re-install, but the same syntax error occured.

I even tried to re-install, but the same syntax error occured.

screenshot image

To Reproduce Steps to reproduce the behavior:

  1. start/install toolkit
  2. wait till updates completed
  3. See error

Expected behavior start of the toolkit

Screenshots

screenshot image

System:

sdomi4 commented 1 year ago

This is usually down to DataDragon not being updated/available, although it should be as far as I know. If it doesn't work by tonight we'll take a look at what might be going wrong.

As a workaround, you might be able to set last-downloaded-version: to 13.15 manually and the download is skipped (although you might lack some assets then).

benholness commented 1 year ago

Hey @sdomi4, which file do you update the last-downloaded-version? I'll try this now as I'm having the same issue (both existing download and fresh install)

sdomi4 commented 1 year ago

Sorry, should have mentioned it - its in ...\prod-toolkit\modules\plugin-config\config.json

benholness commented 1 year ago

No worries! Thank you :)

benholness commented 1 year ago

Hi @sdomi4, I've added it in, saved the file and done start.bat but it doesn't seem to be skipping over the DataDragon download and is still crashing. Any thoughts on this?

sdomi4 commented 1 year ago

I've taken a quick look; It seems that one of the paths changed in CommunityDragon. We'll need to update the static module to fix this.

sdomi4 commented 1 year ago

This line will need to be updated to the new filename in CDragon. The new URL for the file is: https://raw.communitydragon.org/latest/game/items.cdtb.bin.json

The change comes from Riot changing a filename, might not be permanent.

sdomi4 commented 1 year ago

Should be fixed with an update of module-league-static to 3.10.0. If you manually set a last-downloaded-version in the config, make sure to clear the value to force a full download of assets.

MDvorky commented 1 year ago

@sdomi4 Where can i found the value to force a full download?

sdomi4 commented 1 year ago

As a workaround, you might be able to set last-downloaded-version: to 13.15 manually and the download is skipped (although you might lack some assets then).

Here, located in the config file at ...\prod-toolkit\modules\plugin-config\config.json

MDvorky commented 1 year ago

I don't have it. I cannot see it here

benholness commented 1 year ago

Should be fixed with an update of module-league-static to 3.10.0. If you manually set a last-downloaded-version in the config, make sure to clear the value to force a full download of assets.

Quick question @sdomi4, how do you update modules? Apologies if this is super obvious

sdomi4 commented 1 year ago

In the toolkit webpage, go to the modules page and you should have an update button for all modules where updates are available. Make sure to restart the toolkit after updating so everything works properly.

MDvorky commented 1 year ago

I cannot reach the webpage without updating tool.

MDvorky commented 1 year ago

As a workaround, you might be able to set last-downloaded-version: to 13.15 manually and the download is skipped (although you might lack some assets then).

Here, located in the config file at ...\prod-toolkit\modules\plugin-config\config.json

image

MDvorky commented 1 year ago

I don't have it

sdomi4 commented 1 year ago

I cannot reach the webpage without updating tool.

Good point - You can update the module by hand by downloading the 3.10.0 release module-league-static.zip and copying everything into ...\prod-toolkit\modules\module-league-static\ and overwriting existing files.

I don't have it

Yes you do, it's on line 10

MDvorky commented 1 year ago

Even if i clear the value and copied by hand new static, it is still downloading new.

sdomi4 commented 1 year ago

That sounds like working as intended? Or is it still crashing?

MDvorky commented 1 year ago

It is working indeed :) Thank you very much

benholness commented 1 year ago

Just wanted to say it's working too @sdomi4, thank you for your help today on this. I'll let you know if I come across anything when I cast later today.