RCVolus / lol-pick-ban-ui

Web-Based UI to display the league of legends champ select in esports tournaments.
MIT License
243 stars 69 forks source link

Application displays summoner names but not champions #45

Closed hottubdan closed 3 years ago

hottubdan commented 3 years ago

Hi there,

I had the tool up and running for several weeks, and now it does not pull any champion icons. It displays summoner names, and the correct timer up top, but For bans and picks, it never shows the champions. Has anyone else had this issue?

PieterVanZyl-Dev commented 3 years ago

This tends to be due to the fact that a new patch was recently released and the images coming from ddragon isn't available yet.

Try and go into the config file and set the patch version down one version and see if that resolves the issue.

The patch files/images tends to take a week or more before it's live on dragon

On Wed, Nov 4, 2020 at 3:12 AM hottubdan notifications@github.com wrote:

Hi there,

I had the tool up and running for several weeks, and now it does not pull any champion icons. It displays summoner names, and the correct timer up top, but For bans and picks, it never shows the champions. Has anyone else had this issue?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RCVolus/lol-pick-ban-ui/issues/45, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5AJOOETFE6D5XWTCGBTE3SOCTBBANCNFSM4TJNZIEA .

Laraakaa commented 3 years ago

This is most probably related to the cache, yes.

I just tried it locally to see if there is an issue with the data provider service (which is part of a Riot API called datadragon). Everything seems to be okay.

Can you please remove your folder cache/10.22.1 and restart the application to trigger a redownload? Usually this should fix the issue.

Laraakaa commented 3 years ago

Sorry closed it by accident

hottubdan commented 3 years ago

Hey! I appreciate the replies.

I've tried both methods and it doesn't seem to work. When I try and delete the cache, it does re download the assets, but looking at the cache folder, specifically the champion splash arts, all of the "centered" splash arts aren't loading for me. They are .jpg files, like the others, but won't load properly. Not sure if that has anything to do with it.

Laraakaa commented 3 years ago

Hmm that's interesting. The normal images are retrieved from DataDragon, which is an official service directly provided by Riot. The centered images are not available there, they are extracted by the community out of the client and put on the inofficial CommunityDragon, which is similar to the DataDragon but offers more data. It may be that either the CommunityDragon was temporarily unavailable, or that your connection to it may not work.

For example for the latest patch, the champion image for Soraka would be available here: https://cdn.communitydragon.org/10.25.1/champion/soraka/splash-art/centered (this is also where the tool downloads it from).

Laraakaa commented 3 years ago

closing for inactivity, feel free to reopen if the issue persists

ihabdz55 commented 3 years ago

i have the same probleme a fix plz ?