NPM Start not working on layout-volu-europe

Fivxs commented 3 years ago

Everything works, but when i do NPR start on layout-volu-europe it opens google tells me it doesnt work, even thought i used the link provided on the GIT website. It also shows this error on powershell. Any fix for this? Thanks! ![Uploading Screenshot_2.png…]()

helderdiin commented 3 years ago

I'm having the same problem. Using the http://localhost:3000?backend=ws://localhost:8999 as mentioned on README, it doesn't work...

Even if I ignore that and start the Pick Ban phase, on terminal it start the ChampSelect: 2021-06-21T18:25:42.913Z [info ] Controller : ChampSelect started! but page still with the error The "path" argument must be of type string.

Someone can help with that?

Using the layout-simple way, its work fine!

vsumpi commented 3 years ago

Yeah the same problem here

LuzrodGaming commented 3 years ago

Also same problem here

Grayknife commented 3 years ago

Hey, i could not figure out the exact point where the script breaks, but this error occurs due to a package update of layout-volu-europe, especially react-dev-utils and ws .

@Fivxs @sumpidesign @LuzrodGaming @helderdiin My fix was that i went to an older version of package.json. Be sure that you edit the file in layout-volu-europe folder and not the file of the root project folder.

Remove the node_modules folder completly in layout-volu-europe.

Replace the whole package.json content with the following lines of code:

{
"name": "layout-volu-europe",
"version": "0.1.0",
"private": true,
"dependencies": {
"@babel/core": "7.5.5",
"@svgr/webpack": "4.3.2",
"@typescript-eslint/eslint-plugin": "1.13.0",
"@typescript-eslint/parser": "1.13.0",
"babel-eslint": "10.0.2",
"babel-jest": "^24.8.0",
"babel-loader": "8.0.6",
"babel-plugin-named-asset-import": "^0.3.3",
"babel-preset-react-app": "^9.0.1",
"camelcase": "^5.2.0",
"case-sensitive-paths-webpack-plugin": "2.2.0",
"classnames": "^2.2.6",
"css-loader": "2.1.1",
"dotenv": "6.2.0",
"dotenv-expand": "4.2.0",
"eslint": "^6.1.0",
"eslint-config-react-app": "^5.0.2",
"eslint-loader": "2.2.1",
"eslint-plugin-flowtype": "^4.3.0",
"eslint-plugin-import": "2.18.2",
"eslint-plugin-jsx-a11y": "6.2.3",
"eslint-plugin-react": "7.14.3",
"eslint-plugin-react-hooks": "^1.6.1",
"file-loader": "3.0.1",
"fs-extra": "7.0.1",
"html-webpack-plugin": "4.0.0-beta.5",
"identity-obj-proxy": "3.0.0",
"is-wsl": "^1.1.0",
"jest": "24.8.0",
"jest-environment-jsdom-fourteen": "0.1.0",
"jest-resolve": "24.8.0",
"jest-watch-typeahead": "0.3.1",
"less": "^3.10.3",
"less-loader": "^5.0.0",
"mini-css-extract-plugin": "0.5.0",
"optimize-css-assets-webpack-plugin": "5.0.3",
"pnp-webpack-plugin": "1.5.0",
"postcss-flexbugs-fixes": "4.1.0",
"postcss-loader": "3.0.0",
"postcss-normalize": "7.0.1",
"postcss-preset-env": "6.7.0",
"postcss-safe-parser": "4.0.1",
"react": "^16.9.0",
"react-app-polyfill": "^1.0.2",
"react-dev-utils": "^9.0.3",
"react-dom": "^16.9.0",
"resolve": "1.12.0",
"resolve-url-loader": "3.1.0",
"sass-loader": "7.2.0",
"semver": "6.3.0",
"style-loader": "1.0.0",
"terser-webpack-plugin": "1.4.1",
"ts-pnp": "1.1.2",
"url-loader": "2.1.0",
"webpack": "4.39.1",
"webpack-dev-server": "3.2.1",
"webpack-manifest-plugin": "2.0.4",
"workbox-webpack-plugin": "4.3.1",
"ws": "^7.1.2"
},
"scripts": {
"start": "node scripts/start.js",
"build": "node scripts/build.js",
"test": "node scripts/test.js"
},
"eslintConfig": {
"extends": "react-app"
},
"browserslist": {
"production": [
  ">0.2%",
  "not dead",
  "not op_mini all"
],
"development": [
  "last 1 chrome version",
  "last 1 firefox version",
  "last 1 safari version"
]
},
"jest": {
"roots": [
  "<rootDir>/src"
],
"collectCoverageFrom": [
  "src/**/*.{js,jsx,ts,tsx}",
  "!src/**/*.d.ts"
],
"setupFiles": [
  "react-app-polyfill/jsdom"
],
"setupFilesAfterEnv": [],
"testMatch": [
  "<rootDir>/src/**/__tests__/**/*.{js,jsx,ts,tsx}",
  "<rootDir>/src/**/*.{spec,test}.{js,jsx,ts,tsx}"
],
"testEnvironment": "jest-environment-jsdom-fourteen",
"transform": {
  "^.+\\.(js|jsx|ts|tsx)$": "<rootDir>/node_modules/babel-jest",
  "^.+\\.css$": "<rootDir>/config/jest/cssTransform.js",
  "^(?!.*\\.(js|jsx|ts|tsx|css|json)$)": "<rootDir>/config/jest/fileTransform.js"
},
"transformIgnorePatterns": [
  "[/\\\\]node_modules[/\\\\].+\\.(js|jsx|ts|tsx)$",
  "^.+\\.module\\.(css|sass|scss)$"
],
"modulePaths": [],
"moduleNameMapper": {
  "^react-native$": "react-native-web",
  "^.+\\.module\\.(css|sass|scss)$": "identity-obj-proxy"
},
"moduleFileExtensions": [
  "web.js",
  "js",
  "web.ts",
  "ts",
  "web.tsx",
  "tsx",
  "json",
  "web.jsx",
  "jsx",
  "node"
],
"watchPlugins": [
  "jest-watch-typeahead/filename",
  "jest-watch-typeahead/testname"
]
},
"babel": {
"presets": [
  "react-app"
]
},
"devDependencies": {}
}

run npm install
run npm start
Check url again in browser http://localhost:3000?backend=ws://localhost:8999 . (adjust ports if you run services on other ports than provided default)

LuzrodGaming commented 3 years ago

Hey @Grayknife , after applying this, another error comes

Laraakaa commented 3 years ago

Please check the readme on how to solve that error: https://github.com/RCVolus/lol-pick-ban-ui#syntaxerror-failed-to-construct-websocket-the-url-undefined-is-invalid

Grayknife commented 3 years ago

@LuzrodGaming This is fine. The URL parameter where backend runs is missing. Try: http://localhost:3000?backend=ws://localhost:8999 the part backend=ws://localhost:8999 is important.

LuzrodGaming commented 3 years ago

Succeeded :) Thx guys

github-actions[bot] commented 2 years ago

Closing issue after 2 weeks of inactivity. Please reopen the issue if you need additional help.

RCVolus / lol-pick-ban-ui

NPM Start not working on layout-volu-europe #98