search

RCXcrafter / EmbersRekindled

Port of Embers Rekindled to a minecraft version beyond 1.12.2
MIT License
11 stars 7 forks source link

Don't broadcast messages. #38

Closed Raycoms closed 3 months ago

Raycoms commented 3 months ago

https://github.com/RCXcrafter/EmbersRekindled/blob/rekindled/src/main/java/com/rekindled/embers/blockentity/FluidPipeBlockEntityBase.java#L291

A bunch of the blocks got broadcast mechanics. This causes a lot of network lag on servers. These messages should only be sent to closeby players

Raycoms commented 3 months ago

On that note, why are you not using normal blockentity client sync for this?

RCXcrafter commented 3 months ago

Yeah this was brought to my attention a few days ago, I'm currently working on fixing it.

RCXcrafter commented 3 months ago

It should be good now in version 1.3.2