search

RCasatta / electrsd

Utility to run a regtest electrsd process connected to a given bitcoind instance, useful in integration testing environment.
MIT License
21 stars 17 forks source link

Features are not additive #73

Open tcharding opened 1 year ago

tcharding commented 1 year ago

The features are not additive, this means running cargo test --all-features doesn't work.

The problem is the electrs/esplora features used to define VERSION, perhaps there is another way?

#[cfg(feature = "electrs_0_8_10")]
const VERSION: &str = "v0.8.10";

#[cfg(feature = "esplora_a33e97e1")]
const VERSION: &str = "esplora_a33e97e1a1fc63fa9c20a116bb92579bbf43b254";

#[cfg(feature = "electrs_0_9_1")]
const VERSION: &str = "v0.9.1";

#[cfg(feature = "electrs_0_9_11")]
const VERSION: &str = "v0.9.11";
RCasatta commented 1 year ago

Yes, Andrew fixed this in bitcoins with a clever approach https://github.com/RCasatta/bitcoind/pull/117 It needs to be ported also here

RCasatta commented 1 year ago

Mmmh, here we also have the issue of esplora_a33e97e1 which is not strictly growing but forking...