RCayre
commented
4 years ago Hi, thank you for this issue. I have managed to reproduce the problem with one of my phone, however the fix is probably not enough. On some phones, the bt_stack.conf is not updated and doesn't contain BtSnoopFileName and BtSnoopLogOutput, so it's probably not a good idea to use only this file to know if the option is enabled and where the log file is. I think the best option could be to use the bt_stack.conf file if it's available, and the hardcoded / find way if it's not. There was also a mistake in my code (the found boolean was inverted, so it didn't stop the execution if the log file wasn't found). Can you tell me if the following code works with your phone ?
def _getSnoopFileLocation(self):
stdout, _, returncode = self._runADBCommand("cat /etc/bluetooth/bt_stack.conf | grep BtSnoopLogOutput")
if returncode == 0:
# The option has been found in the bt_stack.conf file
snoopEnabled = ((stdout.decode('ascii').replace("\n","")).split('=')[1] == "true")
stdout, _, returncode = self._runADBCommand("cat /etc/bluetooth/bt_stack.conf | grep BtSnoopFileName")
if returncode == 0:
path = (stdout.decode('ascii').replace("\n","")).split('=')[1]
_,_,returncode = self._runADBCommand("test -f "+path)
return (snoopEnabled and returncode == 0,path)
else:
# The option has not been found in the bt_stack.conf file
possiblePaths = [
"/sdcard/btsnoop_hci.log",
"/data/log/bt/btsnoop_hci.log", # Samsung
"/sdcard/MIUI/debug_log/common/btsnoop_hci.log" # MIUI
]
for path in possiblePaths:
_,_,returncode = self._runADBCommand("test -f "+path)
if returncode == 0:
return (True,path)
stdout, _, returncode = self._runADBCommand("find /sdcard/* -name btsnoop_hci.log | head -n1")
print(stdout.decode('ascii').replace("\n","") != "")
return (stdout.decode('ascii').replace("\n","") != "",stdout.decode('ascii').replace("\n",""))
whoot
Hey,
getting the Bluetooth HCI-Snoop log from the device is a nice idea, however I see some problems with your code.
Some additional background info The btsnoop hci log seems to be getting phased out of the user-accessible areas on a lot of phones (you need root access). Trying to enable the logging does not work - it is enabled in the developer options, but if you look into the config (_/etc/bluetooth/btstack.conf), the value of BtSnoopLogOutput is still false => Enabling the option is ignored.
This is the reason why running Mirage on such devices (like mine) will produce the following error message on runtime:
--
The FIX
First of all, dont use harcoded paths for specific devices. Get the path of the log file from the bluetooth config:
Also checking the socket is not enough. Check if the option is actually enabled:
Including this checks, the output may look something like this:
If you want, I can create a pull request.