RConsortium / submissions-pilot3-adam

Development repo for pilot3 submission to FDA - ADaM
https://rconsortium.github.io/submissions-pilot3-adam/
GNU General Public License v3.0
16 stars 11 forks source link

Closes #127: replace `round_sas` by `round_half_up` #128

Closed kaz462 closed 1 year ago

kaz462 commented 1 year ago

@robertdevine raised a good point for using tidytlg:roundSAS instead of round_sas

Also, the current project level round_sas has this issue, although no impact on pilot3.

janitor::round_half_up has the same functionality as tidytlg:roundSAS, since janitor is already in our renv.lock file, will use janitor::round_half_up to avoid updating the lock file

laxamanaj commented 1 year ago

Thanks for checking @bms63 . I'll merge.