search

RConsortium / submissions-pilot3-adam

Development repo for pilot3 submission to FDA - ADaM
https://rconsortium.github.io/submissions-pilot3-adam/
GNU General Public License v3.0
16 stars 11 forks source link

Conflation of Pilot3 Issues #95, #135, #137, #138, and #139 per the discussion in the Issue #135 PR thread #140

Closed robertdevine closed 9 months ago

robertdevine commented 9 months ago

Per the Issue #135 PR discussion, tidying to capture (i)efficiencies by linking the R Consortium WG Meeting Minutes starting with the October 2023 FDA Feedback with Planned Scheduling of the FDA Review Period and (ii)Pilot3 Team compilation of FDA Pilot3 Submission Feedback including the Pilot3 Team Issue Interpretation(s) as the FDA Review continues.

Looks like lints fail during checks. I'll take a look. I think we saw this lints issue before. Thx.

image

Looks like a couple of stray chars, getting late, tomorrow I'll tidy a bit more and update the PR. Thx.

image

image

@bms63 and @laxamanaj - have it down to a single lintr error otherwise looks good - the Pilot3 URL in pkgdown yaml is not passing lint - we'll get it...I'll take a look.

image

bms63 commented 9 months ago

Hi @robertdevine - I was trying to fix the lintr issue when updating the pkg yml.

I think the headline ("Feedback from the FDA") of the menu might need ot be updated if we are listing out the minutes for the meetings as well as specific feedback given to the FDA.

Perhaps "Working Group Minutes and Regulatory Feedback" or "WG Minutes and Regulatory Feedback"?

image

bms63 commented 9 months ago

I managed to reduce the number of lintr issues. We can put in nolints to deal with the commented out code sections.

Thanks @bms63, the update to the headline ("Feedback from the FDA") and "What's on the website section?" will be "WG Minutes and Regulatory Feedback".

robertdevine commented 9 months ago

@bms63 and @laxamanaj - good to go on it. PR and Issue #140 pass all checks. This should address all of the discussion points following PR #135. Should be all set for the February 2024 WG General Meeting and further feedback from FDA. Thanks. again

robertdevine commented 9 months ago

Thanks @bms63 and @laxamanaj. Should be all set. Further tidying, (i)re-enabled the commented_code_linter, (ii)updated the Pilot3 website home page What's on the Website? paragraph WG Minutes and Regulatory Feedback menu noting two sections [links to monthly WG Meeting Minutes, link to Pilot3 Team Compilation and Interpretation(s) of the specific feedback from FDA as the Regulatory Review continues], and (iii)redacted commented code sections from the report-tlf-pilot3.Rmd source file. The redacted sections of commented out code should have little impact to reviewers. Thx. [Tested lintr and static analysis in posit cloud and on R Studio VM and bare metal.]