Remove comments in ADTTE

bms63 commented 1 year ago

SHAESEN2 commented 1 year ago

I think comments are helpful. Not sure why they need to be deleted.

laxamanaj commented 1 year ago

Hi, @SHAESEN2 . Agree comments are useful. I think we were specifically talking about these comments in adtte.R, currently.

# First dermatological event (ADAE.AOCC01FL = 'Y' and ADAE.CQ01NAM != '')

# TRTEMFL
#' If ASTDT >= TRTSDT > . then TRTEMFL='Y'. Otherwise TRTEMFL='N'

# CQ01NAM
#' If AEDECOD contains ('APPLICATION', 'DERMATITIS', 'ERYTHEMA', 'BLISTER') OR
#' if AEBODSYS='SKIN AND SUBC UTANEOUS TISSUE DISORDERS'
#' but AEDECOD is not in ('COLD SWEAT', 'HYPERHIDROSIS', 'ALOPECIA')
#' then CQ01NAM='DERMATOLOGIC EVENTS' Otherwise CQ01NAM=NULL

# AOCC01FL
#' Subset to CQ01NAM=''and TRTEMFL='Y' <- error in define, this should be CQ01NAM != ""
#' sort by Subject (USUBJID), Start Date (ASTDT), and Sequence Number (AESEQ)
#' flag the first record (set AOCC01FL='Y') within each Subject

I think the comments above should be removed as these specs for these three variables should be, if not already, in the define under ADAE and shouldn't have to be another comment here.

I suggest to simplify and just take the comment # First dermatological event and put it right above the code deriving the event (example below) :

# First dermatological event 
event <- event_source(
  dataset_name = "adae",
  filter = AOCC01FL == "Y" & CQ01NAM == "DERMATOLOGIC EVENTS" & SAFFL == "Y",
  date = ASTDT,
  set_values_to = vars(
    EVNTDESC = "Dematologic Event Occured",
    SRCDOM = "ADAE",
    SRCVAR = "ASTDT",
    SRCSEQ = AESEQ
  )
)

RConsortium / submissions-pilot3-adam

Remove comments in ADTTE #69