search

RDCEP / EDE

MIT License
2 stars 1 forks source link

Refactor #13

Closed njmattes closed 8 years ago

njmattes commented 8 years ago

@ricardobarroslourenco @legendOfZelda I think it might be time to refactor this rdcep/ede repo to include the various bits of code that have been worked on over the last few weeks. I propose we start a refactor branch of this repo, and start collecting all the changes that have been made elsewhere. I know we've stubbed out new models and API endpoints that all should be added into this refactor branch.

Since we're forked from Plenario, perhaps we need to keep their MIT license? Their license is here: https://github.com/UrbanCCD-UChicago/plenario/blob/master/LICENSE.

njmattes commented 8 years ago

This morning started a develop branch, and a refactor_0316 branch. I'll update the server with this, do some basic testing, and then merge it into develop and we can continue to work there. Hope to get that done today, but I have to teach this afternoon.

ghost commented 8 years ago

yep, need LICENSE, which is there in refactor_0316, good. time to get up to speed with git, certainly for me.

njmattes commented 8 years ago

I'm not a licensing whiz unfortunately. This license contains: Copyright (c) 2014 The University of Chicago and DataMade. Are we obligated by the MIT license to retain the original unmodified copyright holder? Anyone know what the best practice is here?

ghost commented 8 years ago

i think we should do it according to: http://programmers.stackexchange.com/questions/157968/how-to-manage-a-copyright-notice-in-an-open-source-project, i.e. according to the last 'code' block in the answer, i.e. just adding our copyright right under the existing and use 'Original work' / 'Modified work' to distinguish them.

njmattes commented 8 years ago

I like it. So, who is the (c) holder of the modified code after all? Does UChicago own the (c) on the work of its staff / faculty / students? Since the DePaul subaward is funding Ricardo and I, does DePaul's IP protocol factor in (DPU doesn't take (c) ownership from its staff / faculty / students)?

ricardobarroslourenco commented 8 years ago

Hi folks, sorry about the delay in answering. I'm through my final works so I've been extra busy. On my way of see DePaul should have some part on this, but actually I don't know how this works. I remember some licensing discussion with @abrizius some months ago about an UChicago office that deals with this. Perhaps we should get some guidance.

ghost commented 8 years ago

it's probably going to be

Original work Copyright (c) 2014 The University of Chicago and DataMade
Modified work Copyright (c) 2016 [***]

where *** = The University of Chicago and DePaul University (or more specific because of subaward) but of course let's get some guidance to be on the safe side.

njmattes commented 8 years ago

Last conversation I had with anyone at DePaul about this, the upshot was that DePaul wanted no ownership of intellectual property, and that the copyright / trademark / patent / etc. was wholly owned by the individual. We could always double check with ORS.

njmattes commented 8 years ago

The basic refactoring is done, and has been merged with the develop branch. I'm closing this issue, and will open another for copyright issues. And perhaps another for more fundamental licensing questions.