Closed njmattes closed 8 years ago
i haven't used id
so far because it's a keyword in python
yes, I'm fine with your schema. only minor suggestions:
Grid_Var
(singular) but the underlying table grid_vars
(plural) because the object really stands for one row, thus singularvar_id
instead of vars_id
I'm fine with that. We should rip out the @declared_attr
of the EDEBase
object, and add __table_name__
s back to the model objects. Do you want to do this refactor or want me to? I'm happy to do it—or to stay out of the way.
ok, i refined the schema and actually removed EDEBase
to simplify + make the uid's
and tablenames more explicitly visible in models.py
which can't hurt, certainly not for the beginning.
Works for me.
@legendOfZelda Is it possible to change the database schema so that each table's
primary_key
is calledid
(rather than eggid
)?ForeignKeys
would still take names likegid
to distinguish themselves. See the following files in thedb_ids
branch for a sense of what I'm talking about:ede/database.py:18–29
ede/schema/models.py