RDCEP / EDE

MIT License
2 stars 1 forks source link

Return metadata uid's in API response #29

Closed njmattes closed 8 years ago

njmattes commented 8 years ago

@legendOfZelda We need to also return the uid for each metadata object when users make requests to /api/v0/metadata/<intlist>. This is so the uid exists on the frontend and can be added to future requests.

ghost commented 8 years ago

but the intlist in /api/v0/metadata/<intlist> already contains the uid's so the users already need to know them prior to issuing /api/v0/metadata/<intlist>. so we should rather return the uid's already in the response of a /api/v0/metadata request

njmattes commented 8 years ago

We need to return them for /api/v0/metadata/, and for the sake of symmetry (and validation) we should return them for api/v0/metadata/<intlist> as well. Also because it's not transparent that if I request 3,7,1 if those are returned in the order requested, or in ascending order, or in the order their keys were last accessed in the db, etc.

ghost commented 8 years ago

@njmattes just wanted to tell you that i put back the:

fields into the response json.

njmattes commented 8 years ago

Righteous. I've got some changes to the API locally that haven't been pushed yet. I just finished the bulk of my duties for these ongoing faculty searches, so should be back to EDE / ATLAS this week. Which branch are these changes on? I'll merge before I push everything.

ghost commented 8 years ago

in 'severin' and already merged into 'develop'

njmattes commented 8 years ago

Ah cool. I'll just pull and merge then. Thanks.