RDFBones / RDFBones-O

An RDF ontology for research data from physical anthropology and related fields of expertise.
4 stars 1 forks source link

Missing Sortinglabels in dentalwear #159

Closed zarquon42b closed 2 years ago

zarquon42b commented 2 years ago

The LabelSorting items are missing for <http://w3id.org/rdfbones/ext/wearpatterns/LargeDentineAreaWithEnamelRimComplete> <http://w3id.org/rdfbones/ext/dentalwear/QuadrantWornFlatNoDentineExposure>

Code to find out values with missing sorting index:

PREFIX obo: <http://purl.obolibrary.org/obo/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX owl: <http://www.w3.org/2002/07/owl#>
             SELECT DISTINCT $value ?index WHERE {
             ?myclass  rdfs:subClassOf ?myRS1 .
              FILTER (?myclass IN (<http://w3id.org/rdfbones/ext/phaleron-di/WearOfIncisorsAndCaninesValueSpecification> , <http://w3id.org/rdfbones/ext/dentalwear/WearOfMolarsValueSpecification> ))

              ?myRS1 a owl:Restriction ;
                            <http://www.w3.org/2002/07/owl#onProperty> <http://purl.obolibrary.org/obo/OBI_0000999> ;
                            owl:someValuesFrom|owl:onClass ?selection .
        ?selection owl:oneOf/rdf:rest*/rdf:first ?value .
             FILTER(not exists {?index obo:IAO_0000136 ?value}) .        
}  
cuboideum commented 2 years ago

The problem with the wearpatterns item lies here:

https://github.com/RDFBones/Phaleron-DentalInventory/blob/robot/Template_PhaleronDI-ValueSpecifications.tsv#L27

The referenced category label is misnamed as "wearpatterns:LargeDentineAreaWithEnamelRimComplet".

cuboideum commented 2 years ago

Sorting for http://w3id.org/rdfbones/ext/dentalwear/QuadrantWornFlatNoDentineExposure is obsolet because molar wear scores are numbers, not categories, as pointed out by issue https://github.com/RDFBones/RDFBonesPhaleron/issues/69.

cuboideum commented 2 years ago

Fixed with commit https://github.com/RDFBones/Phaleron-DentalInventory/commit/102df25cb363199f102b7f25ff0a92f08bceb59e.

cuboideum commented 2 years ago

@zarquon42b: The changes from commit https://github.com/RDFBones/Phaleron-DentalInventory/commit/102df25cb363199f102b7f25ff0a92f08bceb59e are also reflected in the robot branch of the RDFBones-AppOntology repository.