RDFBones / RDFBones-O

An RDF ontology for research data from physical anthropology and related fields of expertise.
4 stars 1 forks source link

[phaleron-patho] Wrong class in Create New PBP-Paleopathology Instance query #175

Closed 15E601 closed 1 year ago

15E601 commented 1 year ago

Was browsing Ontodia and noticed this: Screenshot from 2023-01-19 19-38-19 Class phaleron-patho:PaleopathologyInvestigation isn't linked to any ontology. There's an error in the creation query.

The SPARQL line ?myPPprocess a <http://w3id.org/rdfbones/ext/phaleron-patho/PaleopathologyInvestigation> . in the template http://www.metaphacts.com/resource/PBP_Patho_CreatePaleopath needs to be changed to ?myPPprocess a <http://w3id.org/rdfbones/ext/phaleron-patho/PaleopathologicalInvestigation> . which is the actual class in phaleron-patho

zarquon42b commented 1 year ago

Suggestion: rename the class in the ontology, as there is already an existing class called <http://w3id.org/rdfbones/ext/phaleron-dpatho/DentalPaleopathologyInvestigation> and the naming would be more consistent that way. I now also assigned @cuboideum to look into this.

cuboideum commented 1 year ago

Of course it is possible to change the URI of the class. But are you sure you have not referenced the existing URI elsewhere in AnthroGraph?

cuboideum commented 1 year ago

@zarquon42b: What ist the verdict? Shall I change the class URI in the ontology?

zarquon42b commented 1 year ago

We are currently only using <http://w3id.org/rdfbones/ext/phaleron-patho/PaleopathologyInvestigation> throughout the database which is not defined. I would suggest changing the URI of <http://w3id.org/rdfbones/ext/phaleron-patho/PaleopathologicalInvestigation> to <http://w3id.org/rdfbones/ext/phaleron-patho/PaleopathologyInvestigation>. Otherwise I have to fix those triples as well. Can we please not make it a habit of changing URIs of classes already deployed? BTW: My original statement is from January - before we implemented and deployed it.

cuboideum commented 1 year ago

Pull request https://github.com/RDFBones/Phaleron-Pathologies/pull/21 makes the requested change to the Phaleron-Pathologies ontology extension.

cuboideum commented 1 year ago

Commit https://github.com/AnthroGraph/Phaleron-AppOntology/commit/fd15c548e3e13be015f6c7091634bc1b2747f514 updates the Phaleron app ontology.