RDFBones / RDFBonesPhaleron

An RDFBones implementation of the data collection routines developed for the Phaleron Bioarchaeological Project.
1 stars 0 forks source link

No option to put multiple ‘aspects’/‘locations’ for OA/OP lesions in Paleopath modules #76

Closed sacheever closed 1 year ago

sacheever commented 1 year ago

In what module does the bug occur? Skeletal Paleopathology

Describe the bug When entering an OA/OP lesion, after selecting an ROI, the first field under ‘Additional Information’ is: “ Location Of Osteoarthritis Or Osteoporosis Lesion”, which has the standard ‘aspect’ descriptors such as anterior, posterior, medial, lateral, etc. as options in the drop down menu. As with other types of pathology, there is potential to need to list multiple ‘aspects’/‘locations’ for the pathology if the lesion crosses multiple surfaces (for example, if lipping of the proximal epiphysis impacted the anterior AND medial edges of the articular surface). However, you are only able to enter a single location/aspect with no option to add another.

To Reproduce Steps to reproduce the behavior:

  1. Go to any individual and portion of the body
  2. Click on ‘Create New OA/OP entry’
  3. Scroll down to Additional Information
  4. Click on “ Location Of Osteoarthritis Or Osteoporosis Lesion”5.
  5. See error - only one ‘location’/‘aspect’ may be selected.

Expected behavior

There should be an option to ‘add additional Location of Osteoarthrtitis or Osteoporosis’

sacheever commented 1 year ago

@JEB13, @HannahLiedl, @hayesleigh, @jstamer95, @jessica-rothwell

HannahLiedl commented 1 year ago

I agree with Sylvia: it is also necessary for OA to be able to enter multiple aspects affected just we have it with the other pathologies.

zarquon42b commented 1 year ago

Hi everyone, from my side (implementation point of view), this is no big thing and I can change this easily. Please discuss this among yourselves and communicate the final verdict ;)

jstamer95 commented 1 year ago

I agree; great comment Sylvia!

cuboideum commented 1 year ago

At the meeting between the Phaleron Bioarchaeological Project and the RDFBones/AnthroGraph workgroup on 21 October 2022 we agreed that the control should take multiple entries.

zarquon42b commented 1 year ago

Fixed in https://github.com/AnthroGraph/PBP-App/commit/1546b231b320420144ccc764f805697f47257390