RDFBones / RDFBonesPhaleron

An RDFBones implementation of the data collection routines developed for the Phaleron Bioarchaeological Project.
1 stars 0 forks source link

Missing grouped element label #90

Closed hayesleigh closed 8 months ago

hayesleigh commented 1 year ago

In what module does the bug occur? Skeletal paleopathology

Describe the bug Within the skeletal paleopathology module the ROI "entire proximal toe phalanx" is not showing up as an option. I double-checked the skeletal inventory where I noticed the bug individual (IX_872) and proximal foot phalanges are present, so the ROI should show up.

To Reproduce Steps to reproduce the behavior:

  1. Go to Osteo pathology section for individual IX_872-----this error also occurs in the other pathology types (bone addition etc)
  2. Click on leg/foot section.
  3. Scroll down to the osteoarthritis/osteoporosis section and click on prox toe phalanx test.
  4. See error: no ROI option for entire proximal toe phalanx.

Expected behavior Need to add the ROI of entire proximal toe phalanx.

Screenshots

image

Additional context Add any other context about the problem here.

cuboideum commented 1 year ago

I assume that adding the ROIs in question to the ROI groups defining tab affinity will solve the issue.

cuboideum commented 1 year ago

This seems to be a duplicate of issue #52.

cuboideum commented 9 months ago

I have checked the example given in the issue in detail. For individual IX_872 the information from the skeletal inventory is as follows:

So, for the OA/OP section, we would expect the following selection:

However, we only get to choose from 'Entire intermediate phalanx of toe' and 'Entire distal phalanx of toe'.

Behind the scenes of AnthroGraph, what ROIs are on selection in the Paleopathology module is determined by 'Anatomical regions of interest groups'. The group for the lower limb references 'Entire proximal phalanx of toe' but not 'Entire left proximal phalanx of toe' and 'Entire right proximal phalanx of toe'. This could be a reason why the latter two are not displayed. The former we would not even expect, because the skeletal inventory does not list unsided proximal phalanx fragments.

cuboideum commented 9 months ago

The remaining implementation in AnthroGraph is covered by issue https://github.com/AnthroGraph/PBP-App/issues/70.

cuboideum commented 9 months ago

Even after implementation in AnthroGraph, the required ROIs cannot be selected.

This should be because of the missing implementation of ROI verification.

cuboideum commented 9 months ago

https://github.com/AnthroGraph/Phaleron-AppOntology/pull/45 added six new ROIs to the 'Phaleron lower limb regions of interest group'. The 'Osteoarthritis and osteoporosis data set section', however, is about the instance of the 'Phaleron lower limb articular regions of interest group'. As phalanges have articular surfaces, they need to be also added to this group.

cuboideum commented 8 months ago

Fixed with commit https://github.com/AnthroGraph/Phaleron-AppOntology/commit/84976278dd326bfeb658e9561c9ed4d7664f5749.

cuboideum commented 8 months ago

The issue is resolved, the required ROIs can now be selected in the AnthroGraph production instance.