Closed recalcitrantsupplant closed 1 year ago
Can confirm. I have the same issue as @jamiefeiss.
I have a fix coming, should be tomorrow.
Thanks Jamie I'll take a look.
On Mon, 28 Aug 2023, 17:41 Jamie Feiss, @.***> wrote:
@.**** requested changes on this pull request.
After some local testing, I've found two issues:
- For a skos:Concept page, the prez:endpointComponentURI triple seems to be missing:
aarr:chair a skos:Concept ; dcterms:identifier "aarr:chair"^^prez1:identifier ; dcterms:provenance "Developed for this Agent to Agent Roles @. ; rdfs:isDefinedBy https://data.idnau.org/pid/vocab/aarr ; skos:broader aarr:member ; skos:definition "The presiding officer of an assembly, meeting, committee, or @. ; skos:inScheme https://data.idnau.org/pid/vocab/aarr ; skos:prefLabel @.*** ; skos:scopeNote "Organisation to Person relations" ; prez1:link "/v/vocab/vcb:aarr/aarr:chair" .
- For a skos:Collection page, a server error occurs: AttributeError: 'list' object has no attribute 'name', which points to this line:
where the problem seems to be a missing class in the SPARQL query:
VALUES ?class {}
— Reply to this email directly, view it on GitHub https://github.com/RDFLib/prez/pull/145#pullrequestreview-1597661411, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQUSNXFSDPJY7PKTRKH4A3XXRDTVANCNFSM6AAAAAA3J63ICA . You are receiving this because you authored the thread.Message ID: @.***>
@jamiefeiss both fixed now - note I've switched to the dcterms:identifier to include parent URL components / their labels. From the updated notes:
_Add a triple: of the form: <endpoint_component_uri> dcterms:identifier "{curie_id}"^^prez:identifier
for parent CURIEs in endpoints such that the URIs of parents are included in the response, and get annotated, such that labels are available for breadcrumbs._
@edmondchuc I think I've addressed the feedback (just the single suggested change) let me know if I've missed something otherwise will merge
thanks Jamie, not sure if these changes caused that issue, in any case I'd like to merge this in before this PR gets any larger. Could you raise an issue separately? I'll address it when making the filter addition to search.
From dev readme: High Level Sequence
/object
endpointPrez provides a
/object
endpoint as an endpoint that supplies any information known about a given URI. If an annotated mediatype is requested, prez will additionally provide all system links for endpoints which can render the object. The high level sequence for this endpoint is as follows:Return the response
The same functions that are used to do the above have been generally applied to annotated responses. Any annotated response from prez will now:
reference_data/endpoints/
) to find endpoints that can deliver the class(es), and, get a template for these endpoints, specifying any variables that need to be substituted (such as parent URIs).Return the original response + prez:links
Other minor changes:
reference_data/endpoints
)<focus_uri> prez:endpointComponentURI <uri_used_in_endpoint>
<endpoint_component_uri> dcterms:identifier "{curie_id}"^^prez:identifier
for parent CURIEs in endpoints such that the URIs of parents are included in the response, and get annotated, such that labels are available for breadcrumbs.