search

RDFLib / prez

Prez is a data-configurable Linked Data API framework that delivers profiles of Knowledge Graph data according to the Content Negotiation by Profile standard.
BSD 3-Clause "New" or "Revised" License
24 stars 10 forks source link

github action bug + semver #270

Open lalewis1 opened 2 months ago

lalewis1 commented 2 months ago

todo

~- [ ] fix bug in current CI action~

lalewis1 commented 1 month ago

Not sure if this is the same error that was happening previously. But the CI build is failing again after #294

Screenshot From 2024-11-01 14-14-55

It claims that cargo is required (see image) . not sure I believe that though.

I can build locally and its fine. Only difference I can see is in the docker version.

> action is using  26.1.3 and my laptop has 27.3.1

Just wondering if @recalcitrantsupplant or @ashleysommer know what is happening from last time the build was failing, as maybe it is the same thing happening again.

NOTE: Significant change in that PR was an upgrade to the pyoxigraph version.

Also, note that I have realized that the build action is actually building using python 3.11 not 3.12. It does this locally too but still builds successfully so it is not the cause of the current issue, but definitely will be a gotcha later. so just flagging it here as something else to be fixed.

recalcitrantsupplant commented 1 month ago

The wheel for pyoxigraph is not being built for arm (timing out) on the latest version of pyoxigraph, so there's no package on pypi The build is still working for amd 64

I would suggest we wait for the issue to be resolved in pyoxigraph If we really need the arm version we could build from source in the dockerfile

recalcitrantsupplant commented 3 weeks ago

@lalewis1 fyi https://github.com/oxigraph/oxigraph/issues/1077

I think the arm based runners won't be available until early next year, it's likely we should do a release before then, so perhaps we allow the arm build to fail without affecting the amd64 (e.g. separate steps in the action, not sure on the specifics). I won't action this until we need a release though

lalewis1 commented 3 weeks ago

semver implemented in https://github.com/RDFLib/prez/pull/297

other bug still to be fixed

lalewis1 commented 2 weeks ago

noting that there is still a bug with semver, whereby it cannot write to a protected branch. I'm thinking the best solution will be to remove the changelog and pyproj version changes so that no commit is needed by semver to complete the release.