RDFLib / rdflib

RDFLib is a Python library for working with RDF, a simple yet powerful language for representing information.

https://rdflib.readthedocs.org

BSD 3-Clause "New" or "Revised" License

2.11k stars 547 forks source link

Deprecate ConjunctiveGraph (#2405) #2786

Closed wallberg closed 2 weeks ago

wallberg commented 1 month ago

Summary of changes

Deprecate ConjunctiveGraph, in favor of Dataset, as per #2405 .

Checklist

[x] Checked that there aren't other open pull requests for the same change.
[] All tests pass, but lint and mypy do not, I believe due to pre-existing issues.
If the change has a potential impact on users of this project:
- [x] Added or updated tests that fail without the change.
- [x] Updated relevant documentation to avoid inaccuracies.
- [x] Considered adding additional documentation.
[x] Considered granting push permissions to the PR branch, so maintainers can fix minor issues and keep your PR up to date.

wallberg commented 1 month ago

All tests are passing, but this introduces a large number of new warnings about the deprecation. Should I attempt to suppress all of those warnings, as part of this PR?

nicholascar commented 1 month ago

@wallberg thanks for this PR, it's been a long tme coming (5 years, 3 RDFLib major versions...).

We have some issues with PRs passing validation just at the moment. When I return from leave, next week, I will try and fix this issue. Then we will need to see this PR pass the test suite again. If you had it passing locally, it likely will pass fine as the errors we are seeing are, I think, environment issues, not code errors.

So please hold tight for a couple of weeks on this and I we will get this PR through likely in June. I'm really looking forward to greatly improving RDFLib's multi-graph support and this is part of the whole task.

coveralls commented 2 weeks ago

coverage: 91.039% (+0.01%) from 91.028% when pulling 77af6183508f7de34aeabf4d25b72f1c29ddd2cb on wallberg:issue-2405-deprecate-cg into f6de1f3dc23c74665e6d9ac47495463c284b6176 on RDFLib:main.