Add option for custom cert

RDFLib / sparqlwrapper

A wrapper for a remote SPARQL endpoint

https://sparqlwrapper.readthedocs.io/

Other

513 stars 121 forks source link

Add option for custom cert #135

Open abuonomo opened 5 years ago

abuonomo commented 5 years ago

I don't see an easy way to add a custom ca cert for verifying your sparql requests. I made a simple change so that you can easily add a custom cert in your request.

dayures commented 4 years ago

@abuonomo @syats these two PR (#135 #147) are quite similar. From your experience, what could be the best and simplest solution?

abuonomo commented 4 years ago

@dayures I'm not sure if there is a motivation to create an ssl.Context if we are ultimately passing just one cert file. @syats might have a reason for that which I am not totally aware of. From my perspective, I think my solution seems simpler. However, I can see that in the future, even greater extensibility may be offered by allowing for an ssl.Context to be passed to urlopen by the user.